Commits · 95b95b52c59005fbdc173480177b71c97503fb69 · 孙灵跃 Leon Sun / coopwire-hypothesis

13 May, 2020 1 commit
- Hide menu item toggle button if there are no submenu items · 95b95b52
  Kyle Keating authored May 11, 2020
```
Pass undefined to MenuItem to hide the submenu and its toggle button.
```
  95b95b52
11 May, 2020 10 commits

Merge pull request #2152 from hypothesis/fix-toolbar-icon-alignment · 3d0d9330
Robert Knight authored May 11, 2020
```
Fix sidebar vertical toolbar button alignment
```
3d0d9330

Fix sidebar vertical toolbar button alignment · 5277df4c

Robert Knight authored May 11, 2020

The client's test page was missing a `<!DOCTYPE html>` declaration and
as a result rendered in _quirks mode_ rather than _standards mode_. This
hid an issue where the toolbar buttons were not centered correctly in
standards-mode documents.

This incorrect centering was caused by:

 1. The CSS bundle for the "annotator" part of the app not including the
    CSS styles for the `SvgIcon` component
 2. An unnecessary `padding` declaration on the `.annotator-frame-button`
    class

I haven't investigated in detail exactly which quirks-vs-standards mode
difference resulted in the centering still being OK in quirks-mode.

This commit fixes these two issues and fixes toolbar button centering in
both quirks and standards-mode documents.

It also updates the client's test page to add the `<!DOCTYPE html>`
declaration since standards mode is what most web content uses.

5277df4c

Bump dompurify from 2.0.10 to 2.0.11 · dc2d1304

dependabot-preview[bot] authored May 11, 2020

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.10 to 2.0.11.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.10...2.0.11)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dc2d1304

Bump jquery from 3.5.0 to 3.5.1 · d550cd51

dependabot-preview[bot] authored May 11, 2020

Bumps [jquery](https://github.com/jquery/jquery) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](https://github.com/jquery/jquery/compare/3.5.0...3.5.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

d550cd51

Merge pull request #2106 from hypothesis/fix-voiceover-sidebar-toggle · fdbd0f4a
Robert Knight authored May 11, 2020
```
Fix sidebar toggle button when using VoiceOver on iOS
```
fdbd0f4a

Rename `src/annotator/util/{dom -> dom-element.js}` · 90ba126b

Robert Knight authored May 11, 2020

Rename this module to distinguish it from `src/sidebar/util/dom.js`
which are generic DOM utilities that are not ponyfills for standard
methods.

See https://github.com/hypothesis/client/pull/2106/files#r420296891

90ba126b

Fix sidebar toggle button when using VoiceOver on iOS · 1dd909a2

Robert Knight authored May 01, 2020

When using iOS with VoiceOver enabled, double-tapping the sidebar toggle
button caused the sidebar to open and then immediately close. The
immediate close was caused by the `onElementTouchStart` handler in
`guest.coffee` that is intended to hide the sidebar when the user taps
somewhere in the document outside the sidebar. This handler did not
check however whether the event originated from annotator UI or not.

The fix here is to ignore any events which occur inside the sidebar
frame's container.

Fixes #1765

1dd909a2

Merge pull request #2138 from hypothesis/annotator-svg-icons · 12def07b
Robert Knight authored May 11, 2020
```
Use SVG icons in annotator toolbar
```
12def07b

Make annotator icon registration mirror sidebar · b13e835e

Robert Knight authored May 11, 2020

Add `src/annotator/icons.js` which mirrors `src/sidebar/icons.js`. It
contains all the icons used by the "annotator" part of the application.

Remove from `src/sidebar/icons.js` those icons which were not used by
the sidebar but are referenced in tests for annotator components. The
annotator icons are now registered for use in tests by `bootstrap.js`.

b13e835e

Merge pull request #2136 from hypothesis/try-codecov-threshold · af6cb07f
Robert Knight authored May 11, 2020
```
Attempt to squelch spurious tiny codecov failures by setting threshold
```
af6cb07f

07 May, 2020 7 commits
- Adjust button and icon colors and hovers for consistency · 81f6776d
  Lyza Danger Gardner authored May 07, 2020
  
  81f6776d
- Update annotator toolbar to use SVG icons · edd1a8a4
  Lyza Danger Gardner authored May 07, 2020
  
  edd1a8a4
- Add SVG icons needed by annotator · 524443a4
  Lyza Danger Gardner authored May 07, 2020
  
  524443a4
- Make `caret-right` icon consistent with pattern library · 6b68c263
  Lyza Danger Gardner authored May 07, 2020
```
The contents of the `caret-right` icon weren’t consistent with the
`caret-*` icons in the pattern library, but the icon is used by
`Thread`. Rename to `collapsed` (for `Thread` use) and update
`caret-right` to match the pattern library-style carets.
```
  6b68c263
- Merge pull request #2134 from hypothesis/increase-menu-section-contrast · 2e77d8a4
  Robert Knight authored May 07, 2020
```
Make menu section heading slightly darker
```
  2e77d8a4
- Attempt to squelch spurious tiny codecov failures by setting threshold · 283a8d91
  Lyza Danger Gardner authored May 07, 2020
```
We’ve had a lot of `codecov` failures that result from tiny apparent
coverage fluctuations. Set a threshold to attempt to filter out noisy,
meaningless failures.
```
  283a8d91
- Make menu section heading slightly darker · bec06790
  Robert Knight authored May 07, 2020
```
Per the useful notes in `variables.scss`, $grey-5 is the lightest grey
that can be used on a white background for the text to meet WCAG
contrast requirements. This change also makes menu section headings more
consistent with other text in the sidebar.
```
  bec06790
06 May, 2020 17 commits

Merge pull request #2132 from hypothesis/button-labels-and-titles · 4890f94b
Lyza Gardner authored May 06, 2020
```
Add `aria-label` and/or `title` to `<button>` elements
```
4890f94b
Merge pull request #2130 from hypothesis/show-hide-toggles · 9c0d9ed6
Lyza Gardner authored May 06, 2020
```
Add `aria-expanded` to excerpt show/hide toggles
```
9c0d9ed6
Merge pull request #2131 from hypothesis/convenience-config · 42457715
Lyza Gardner authored May 06, 2020
```
Add more properties to sample config in `dev-server`
```
42457715
Merge pull request #2128 from hypothesis/show-sidebar-label · 809f9ab3
Lyza Gardner authored May 06, 2020
```
Change show/hide sidebar button label depending on state
```
809f9ab3
Add `aria-label` where appropriate to `<button>` elements · 539da395
Lyza Danger Gardner authored May 06, 2020

539da395
Add `aria-label` and `title` attrs to `SelectionTabs` · 63559b98
Lyza Danger Gardner authored May 06, 2020

63559b98
Set `aria-label` and `title` attrs only if different from displayed text · 74dbe88f
Lyza Danger Gardner authored May 06, 2020
```
Only set `aria-label` and `title` attributes on `<button>` elements if
they are different from the text displayed in the button.
```
74dbe88f

Add more properties to sample config in `dev-server` · 85b766b9

Lyza Danger Gardner authored May 06, 2020

For developer convenience, add a few more (commented-out) properties
to the config used by the local devserver, and link to more documentation

85b766b9

Add `aria-expanded` to excerpt show/hide toggles · 02047ae4
Lyza Danger Gardner authored May 05, 2020

02047ae4
Merge pull request #2120 from hypothesis/fix-long-url-overflow · 9403c5a1
Lyza Gardner authored May 06, 2020
```
Add word-break rule to prevent long-string overflows
```
9403c5a1
Merge pull request #2129 from hypothesis/fix-new-note-label · c5063edf
Robert Knight authored May 06, 2020
```
Fix "New annotation"/"New page note" label
```
c5063edf

Fix "New annotation"/"New page note" label · 801a9ee3

Robert Knight authored May 06, 2020

The button label should be "New annotation" if text is selected or "New
page note otherwise", but it was the wrong way round.

Fixes a regression introduced in #2102

801a9ee3

Change show/hide sidebar button label depending on state · 5471223e

Robert Knight authored May 06, 2020

Change the sidebar toggle button from being a toggle button with the
label "Show annotation sidebar" to a normal button that changes between "Show
annotation sidebar" and "Hide annotation sidebar" labels.

WAI-ARIA guidelines [1] suggest that both are valid ways of implementing
toggle actions and looking around web and native apps on macOS one can
find plenty of both for similar actions. The one clear
requirement is to use a label change OR aria-pressed, but not both.

We think [2] a label change will make the state slightly easier to quickly
discern and it provides a more useful tooltip for sighted desktop users.

[1] https://www.w3.org/TR/wai-aria-practices-1.1/#button
[2] https://github.com/hypothesis/client/issues/2055#issuecomment-622512247

Fixes https://github.com/hypothesis/client/issues/2055.

5471223e

Merge pull request #2102 from hypothesis/preact-sidebar-toolbar · ff015542
Robert Knight authored May 06, 2020
```
Re-implement the sidebar's vertical toolbar
```
ff015542

Remove an obsolete TODO · 51ccbef9

Robert Knight authored May 06, 2020

This is addressed by the `if @frame` logic a few lines down which only
adds the toolbar if we're providing our own frame.

51ccbef9

Improve several test descriptions · 7568192d
Robert Knight authored May 06, 2020
```
Address PR feedback by rewriting several test descriptions and adding
comments.
```
7568192d

Re-implement the sidebar's vertical toolbar · a4d8fa7f

Robert Knight authored Apr 30, 2020

This commit re-implements the vertical toolbar on the left edge of the sidebar
to make future changes to the toolbar UI easier (eg. some upcoming a11y changes)
and to decouple it from the rest of the annotator application (the toolbar and
`Sidebar`/`Guest` classes currently access each other's internals in a rather
haphazard way).

The new implementation has a similar code structure to the `Adder` toolbar that is
shown when selecting text. It consists of:

1. A Preact component in `src/annotator/components/toolbar`
which renders the toolbar UI according to the current state

2. A controller class in `src/annotator/toolbar.js` which renders the
Preact component into a container element and has provides properties
that the `Sidebar` and `Guest` classes can use to update its state.

The controller takes only the container element and callbacks
associated with each button as inputs, so it no longer calls methods
on the Guest/Sidebar.

The sidebar and guest now update the toolbar UI by setting properties
on the toolbar controller, rather than using a mixture of manual
manipulation of the toolbar DOM and publishing events which get
eventually translated to method calls on the toolbar.

If we convert the remainder of the sidebar UI from jQuery/manual DOM
updates to Preact in future, then we can remove the toolbar
controller entirely and just render the toolbar component from
within the sidebar component.

a4d8fa7f

05 May, 2020 5 commits

Hide the leave group button if allowLeavingGroups is false (#2123) · a813d4e4

Kyle Keating authored May 05, 2020

allowLeavingGroups is a new service level config setting that can globally override the the UI to hide the leave button for a group. This is necessary for section groups in LMS where groups are indeed private, but also can’t be left.

a813d4e4

Add word-break rule to prevent long-string overflows · a3db99b6

Lyza Danger Gardner authored May 04, 2020

Add `word-break` rule to `markdown-view` CSS to
prevent long strings of characters, e.g. URLs,
from breaking out of the sidebar width in replies.

Fixes https://github.com/hypothesis/support/issues/101

a3db99b6

Merge pull request #2124 from hypothesis/cleanup-sidebar-root-css · 25266f9e
Robert Knight authored May 05, 2020
```
Cleanup sidebar CSS
```
25266f9e

Remove unnecessary `em` style · 98a22d89

Robert Knight authored May 05, 2020

This rule is already in the user-agent stylesheet for Safari, Chrome and
Firefox.

98a22d89

Remove obsolete custom element style from `reset.scss` · 1bdd806f
Robert Knight authored May 05, 2020
```
This doesn't belong here and we don't have a `<markdown>` element in the
app any more.
```
1bdd806f