- 07 Apr, 2022 7 commits
-
-
Robert Knight authored
This required a small change in `FilterStatus` to enable TS to better understand the shape of `buttonProps` depending on which code branch is taken.
-
Robert Knight authored
In particular clarify that references to `annotation` refer to an object with only ID properties and not the whole annotation object.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
This found apparent missing checks for a null `profile.userid` (ie. current user is logged out) in several places. These places should not be reachable when the user is logged out due to checks elsewhere, but add explicit checks for the user being logged in.
-
Robert Knight authored
Adapt to current naming conventions for identifiers.
-
Lyza Danger Gardner authored
-
- 06 Apr, 2022 15 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Use shared `TextInput` component for presentational consistency.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Adjust styling of buttons and link in markdown editor toolbar to better handle touch interfaces and focus rings. Also fix casing in `classnames` import.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
This warning is useful to detect situations where the page text and text layer differ beyond just whitespace differences, which will result in misalignment of highlights.
-
Robert Knight authored
Re-use this utility to translate offsets between the original page text and the whitespace-stripped version of the page text. This allows the `stripSpaces` helper to be simplified and avoids creating some offset arrays that are unused.
-
Robert Knight authored
These arose from resolving confusion during a verbal code review.
-
Robert Knight authored
Expand on the choice of "input" and "output" as names for the two string arguments. These could equally have been "source" and "destination" or "stringA" and "stringB".
-
Robert Knight authored
-
Robert Knight authored
When anchoring a quote in a PDF, the quote is first searched in text extracted using PDF.js's `PDFPage.getTextContent` API, and the resulting positions are used to create a range within the hidden text layer of a page. An issue we've seen several times when doing PDF.js upgrades is minor changes to which spaces are included in the text layer. In the past we've adapted our text extraction to match the text layer each time. This slows down the process of upgrading PDF.js and makes maintaining compatibility with a range of PDF.js releases more difficult. In the most recent update, an `includeMarkedContent` option was added to the `getTextContent` API, and the presence of that option could affect whether certain whitespaces are included in the output nor not [1]. Try to address this issue generally by mapping offsets from the page text into offsets in the text layer in a way that ignores whitespace differences. - Add `translateOffsets` utility, which maps a (start, end) pair of offsets in an input string into corresponding offsets in an output string, where the output is a version of the input that has been "corrupted" by the addition or removal of certain characters (eg. whitespace) - Use `translateOffsets` utility in PDF anchoring to map quote offsets in the page text returned by `PDFPage.getTextContent` into offsets in the `textContent` of the text layer element. [1] https://github.com/hypothesis/browser-extension/pull/799#issuecomment-1079864595
-
Robert Knight authored
-
- 05 Apr, 2022 11 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Remove "is" from some state-related reference names.
-
Lyza Danger Gardner authored
This separates out the component styling from the contextual/positioning styling.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Fade the Spinner in slowly on annotation-save such that it only appears if saving the annotation is taking a while. This reduces visual clutter when the annotation saves quickly.
-
Lyza Danger Gardner authored
Fix height-jumping issue with saving message in Annotation
-
dependabot[bot] authored
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1101.0 to 2.1106.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1101.0...v2.1106.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.19.2 to 6.19.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.19.2...6.19.3) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.6.6 to 10.7.0. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.6.6...10.7.0) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 04 Apr, 2022 6 commits
-
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 1.74.2 to 1.74.3. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/1.74.2...1.74.3) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@types/katex](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/katex) from 0.11.1 to 0.14.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/katex) --- updated-dependencies: - dependency-name: "@types/katex" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.6.1...2.6.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.49.9 to 1.49.11. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.49.9...1.49.11) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.5.1 to 13.5.2. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v13.5.1...v13.5.2) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 31 Mar, 2022 1 commit
-
-
Robert Knight authored
Add a test case for pages served with the `Cross-Origin-Opener-Policy: same-origin` header, which currently breaks the client's login popup. This reproduces the issue from https://github.com/hypothesis/product-backlog/issues/1333.
-