1. 24 Jul, 2023 1 commit
  2. 19 Jul, 2023 5 commits
  3. 18 Jul, 2023 1 commit
  4. 17 Jul, 2023 8 commits
  5. 13 Jul, 2023 4 commits
  6. 11 Jul, 2023 1 commit
  7. 10 Jul, 2023 9 commits
  8. 07 Jul, 2023 7 commits
  9. 06 Jul, 2023 4 commits
    • Robert Knight's avatar
      Don't close the sidebar for pointer events within the bounds of the sidebar · 6aeeed8c
      Robert Knight authored
      Fix an issue where clicking in transparent areas of the bucket bar could close
      the sidebar when side-by-side mode is disabled. Such clicks are allowed to
      bubble up to `document.body` because the user may be trying to click on a
      scrollbar thumb or other element in this area. However we don't want these
      clicks to close the sidebar like clicking elsewhere on the document does, as
      this can be annoying if the user was trying to click on eg. a sidebar bucket but
      missed.
      
      In fixing this, the separate mouse and touch event listeners have been replaced
      with a pointer event listener, as this is now supported in all of our target
      browsers.
      6aeeed8c
    • Robert Knight's avatar
      Revise `pointer-events` handling for bucket bar container · b1977ff6
      Robert Knight authored
      In 34521471 the `pointer-events: none` style was
      removed from the bucket bar background. This fixed a problem where clicks
      in-between buckets (eg. when trying to click on a bucket) could cause the
      sidebar to close. It introduced a new issue however where it made clicking on
      page elements behind the bucket bar impossible. This can interfere with clicking
      on scroll bar thumbs in pages where the thumb gets drawn below the Hypothesis
      sidebar for example.
      
      This commit adds `pointer-events: none` back to this container. The next commit
      will address the problem that removing it aimed to resolve, but in a different
      way.
      b1977ff6
    • Alejandro Celaya's avatar
    • Alejandro Celaya's avatar
      2d1673e8