Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 22 Sep, 2020 6 commits
  3. 21 Sep, 2020 6 commits
    • Lyza Danger Gardner's avatar
      Fix case-sensitivity issue with rendering suggested tags. · 6bd09e71
      Lyza Danger Gardner authored 
      The `TagEditor` component formerly did not take casing into account
in its formatting function for suggested tags. The match should be
case-insensitive in the formatter, as it is in the service that does
the filtering of tags.

This is fixed in two ways:

1. Make substring matching in the formatting function case-insensitive.
   Render the substring match according to the suggested tag's casing.
   Fixes this issue specifically.
2. Provide a fallback in the formatter for when the input text does not
   "seem" to match the suggested `item`. In these cases, just render the
   suggested tag as-is. This will prevent the formatter from spazzing
   out if its notion of matching differs from the tag-service's in
   any future case.

Fixes #2547
      6bd09e71
    • Robert Knight's avatar
      Improve some test descriptions and do some small cleanups · 478c173c
      Robert Knight authored 
       - Remove an `Object.assign` in favor of object spread

 - Remove an unused `ctx` argument to `emitGuestEvent`

 - Rewrite several test descriptions for readability

 - Re-order stub initializations in `beforeEach` to be more alphabetical
      478c173c
    • Robert Knight's avatar
      Convert `Guest` tests to JS · bf94d530
      Robert Knight authored 
      This is the result of an automated conversion by decaffeinate followed
by a manual review and clean-up of the result.
      bf94d530
    • Robert Knight's avatar
      Change jQuery `.each()` callback to avoid `this` · a8860c35
      Robert Knight authored 
      To avoid confusion with different meanings of `this` between the
callback and surrounding scope, get the element from callback arguments
instead.
      a8860c35
    • Robert Knight's avatar
      Remove unnecessary fallback value for `Object.keys` call · 048a6c7b
      Robert Knight authored 
      The `options` field is always initialized to an object, so the `|| {}`
is not necessary.
      048a6c7b
    • Robert Knight's avatar
      Convert Guest class to JS · 1f7174f6
      Robert Knight authored
      1f7174f6
  5. 18 Sep, 2020 1 commit
  7. 17 Sep, 2020 6 commits
  9. 16 Sep, 2020 3 commits
  11. 15 Sep, 2020 12 commits
  13. 14 Sep, 2020 1 commit
    • Robert Knight's avatar
      Fix real-time update action processing · 9479612f
      Robert Knight authored 
      When store modules were refactored to only receive their local state in
selectors, the code in `store/modules/real-time-updates` which directly
uses selectors from other modules rather than calling
`store.<selectorMethod>(...)` was not updated to pass in the appropriate
part of the state.

Fixing this resolves two problems:

 - An error when processing notifications of deleted annotations from
   the server. These notifications are currently not getting delivered
   due to a server-side issue (see https://github.com/hypothesis/h/pull/6214).

 - Filtering notifications of new or updated annotations not excluding
   annotations from groups that are not currently focused.

   Fixing this second issue has the side effect that it _appears_ to fix
   https://github.com/hypothesis/support/issues/137 from the user's
   point of view. I say _appears to_ because the backend is still
   incorrectly delivering notifications that the user shouldn't be able
   to see. That is fixed by https://github.com/hypothesis/h/pull/6202
      9479612f
  15. 11 Sep, 2020 3 commits
  17. 10 Sep, 2020 1 commit
    • Robert Knight's avatar
      Convert `Delegator` base class to JS · 2e0eee75
      Robert Knight authored 
      Convert the `Delegator` base class to JS and rewrite the documentation
to match current functionality and usage. Also simplify the `options`
initialization and add a note about why the constructor reads
`this.options` before assigning it.

I tried to convert the `Plugin` class as well but encountered an issue
with interaction between Babel-compiled derived classes and CoffeeScript
sub-classes (in particular, the `BucketBar` class), so it looks like
`Plugin` sub-classes will need to be converted first.
      2e0eee75
  19. 09 Sep, 2020 1 commit
    • Lyza Danger Gardner's avatar
      Remove editing logic from `AnnotationBody`, `Annotation` · 67a1e52b
      Lyza Danger Gardner authored 
      Consolidate annotation-editing logic and sub-components within
`AnnotationEditor`. `AnnotationBody` is for rendering content, and
`Annotation` is relieved of managing editing-related callbacks.

These changes also add a new feature: When saving an annotation,
`AnnotationEditor` will check the contents of `TagEditor`'s input
element. If any text remains there that has not yet bet "committed"
as a tag, that text will be added as a tag. This is to prevent tags
accidentally getting "lost" on save.

Fixes https://github.com/hypothesis/product-backlog/issues/1122
      67a1e52b