- 31 Jul, 2015 1 commit
-
-
Nick Stenning authored
The backend code in `h.streamer` assumes that the arguments to "one_of" are either a non-empty list or a single value. Passing an empty list causes the generation of a bogus query. So, don't update the stream filter until we have at least one URI to stream from. Fixes #2257.
-
- 30 Jul, 2015 7 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
Update to the latest packaging changes of the anchoring helper modules that now specify a browser field and browserify transforms in their package.json files. This bypasses the UMD wrapper of these modules, saving bytes and avoiding the need to wrap them with browserify-shim.
-
Randall Leeds authored
-
Randall Leeds authored
Even when used as a CommonJS module, angular installs itself globally. Rather than fight this in our tests, just leverage it. The mocks module also installs itself under angular.mock. Therefore, none of the require statements for angular or angular-mocks are necessary.
-
Randall Leeds authored
It turns out we don't need Sinon-Chai because we only use the assert interface. According to the Sinon-Chai docs: For assert interface there is no need for this library. Instead, we just install the assertions into the assert object.
-
Randall Leeds authored
There's no reason to have these methods have a different name in the guest as the host. The implementation should be opaque.
-
- 29 Jul, 2015 5 commits
-
-
Nick Stenning authored
Reload annotations on auth change
-
Randall Leeds authored
Just because the user has permission to read an annotation does not imply that it should still be visible under the current search after the authentication change. An example of this is when a NIPSA flagged user logs out but has public annotations visible.
-
Randall Leeds authored
Two front-end fixes
-
Jake Hartnell authored
- Collapsed threads don't show tags - Collapsed threads should have space between user and reply count - "Sign in required" card should have symmetric vertical margins
-
Randall Leeds authored
-
- 28 Jul, 2015 1 commit
-
-
Sean Hammond authored
Consolidate and style the admin interface
-
- 27 Jul, 2015 6 commits
-
-
Randall Leeds authored
While the URL object stringifies nicely, meaning this does work, it is liable to confuse request interceptors that expect a string.
-
Randall Leeds authored
-
Randall Leeds authored
-
Nick Stenning authored
This commit brings together "administrator" views into one place -- the Hypothesis admin console, found at /admin. So far, the only to admin views we have are for flagging/unflagging users as NIPSA, and for administering administrative user status. In the near future, we may also have a feature flag console in here. - I've moved all the admin views into `h.admin` so that we don't confused business logic view functions with administrative view functions, and so that in future it is easier to treat the `/admin` tree as a single entity for the purposes of permissions, etc. - I've added an "admin" page layout, which uses Twitter Bootstrap for basic styling. - I've rejigged both the NIPSA and the administrator users pages to make use of bootstrap.
-
Nick Stenning authored
Update Firefox extension for Jetpack Manager tool
-
Randall Leeds authored
Simpler session service
-
- 24 Jul, 2015 6 commits
-
-
Nick Stenning authored
Rather than using a separate named value to keep track of the current CSRF token, simply treat this as part of the session state.
-
Nick Stenning authored
This commit does three things. In order of importance: - wraps the ngResource for managing session state in a service, which allows us to expose current session state as `session.state` on that instance. This means that components of the application that don't want to alter or explicitly fetch session state, but wish to display some part of it (such as the current authenticated userid, etc.) can do so more easily. - moves configuration of the session resources into the session service rather than requiring configuration from outside via a sessionProvider. - translates the session service to JavaScript from CoffeeScript.
-
Sean Hammond authored
Fix infinite digest cycle caused by feature flag client
-
Nick Stenning authored
This was a fun bug. If multiple feature checks are done in rapid succession when the features cache is empty (such as, for example, during the first digest cycle at application boot time) then the features client would keep kicking off HTTP requests until the first one returned. This would clearly be a misfeature, but wouldn't actually have caused any problems but for the fact that the spinner in `h/directives/simple-search.coffee` does this to determine whether to spin: scope.$watch (-> $http.pendingRequests.length), (pending) -> scope.loading = (pending > 0) This means that kicking off dozens of requests at a time keeps invalidating the digest cycle (because the value of `$http.pendingRequests.length` keeps changing), so it never ends. The result is the ever-horrible `infdig` (infinite digest cycle) error from Angular: https://docs.angularjs.org/error/$rootScope/infdig.
-
Nick Stenning authored
The angular $httpBackend mocking service supports two primary means of usage: .expect(...).respond(...) and .when(...).respond(...) The latter pattern allows a single handler to respond to multiple requests, in any order. The latter is precise -- one .expect() must be matched by one request, in the correct order. This commit changes the tests for the "features" service to use this more precise form of testing.
-
Randall Leeds authored
-
- 23 Jul, 2015 1 commit
-
-
Randall Leeds authored
PDF usages might want to specify relative URLs to get around proxy restrictions with a custom viewer. Even link tags support relative URLs for rel=canonical though it's probably a bad idea as a publisher. In any case, we should clearly just do this.
-
- 22 Jul, 2015 4 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
Make Makefile more dumb
-
Nick Stenning authored
Add support for flagging user accounts as "not in public site areas"
-
Randall Leeds authored
-
- 21 Jul, 2015 9 commits
-
-
Nick Stenning authored
Getting picky with our code styles
-
BigBlueHat authored
-
BigBlueHat authored
Added use strict. Removed unused `attrs` var;
-
BigBlueHat authored
-
BigBlueHat authored
Docs URL line length is a bit too long...
-
BigBlueHat authored
-
Sean Hammond authored
-
Sean Hammond authored
The single it() in this test module was not being run (it was indented inside a beforeEach()) and dedenting it reveals that the beforeEach() is actually crashing anyway (controller somehow not registering with the $controller service, looks like). Rewrite the module to work and be clearer.
-
Nick Stenning authored
Stop two sources of dangling transactions
-