Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 03 Jul, 2023 9 commits
  3. 29 Jun, 2023 2 commits
  5. 26 Jun, 2023 10 commits
  7. 23 Jun, 2023 1 commit
  9. 22 Jun, 2023 3 commits
    • Robert Knight's avatar
      Await `_scrollToAnchor` result · 3bf184ab
      Robert Knight authored 
      This doesn't have a functional consequence, but it is generally appropriate for
async methods not to return until all the work they initiate is done.
      3bf184ab
    • Robert Knight's avatar
      Make top/bottom bucket scrolling work when using a custom bucket container · 6d76d194
      Robert Knight authored 
      When using a custom bucket container, the top / bottom buckets may be positioned
differently than the code previously assumed (137x px below the top of the
viewport, 20px above the bottom). Redo the logic to work regardless of bucket
container positioning. Instead of trying to determine whether an anchor is
on-screen or not, just pick the anchor with the lowest bottom or highest top as
the "nearest" one, depending on which direction we are scrolling in.

This is implemented by:

 - Changing `Bucket` objects to record not just the tags from anchors in
   them, but the list of `AnchorPosition` objects from which the bucket
   was built. These objects include the top and bottom positions of the
   anchor.

 - Make clicking on the "Up" bucket search the anchor list for the
   anchor with the lowest bottom position, and send a request to the
   guest to scroll to that anchor.

 - Make clicking on the "Down" bucket search the anchor list for the
   anchor with the highest top position, and send a request to the
   guest to scroll to that anchor.

 - Removing all the logic for finding and scrolling to the "nearest
   off-screen anchor"
      6d76d194
    • Alejandro Celaya's avatar
      Prevent scrollToAnnotation when key pressed on ThreadCard children · e445b72d
      Alejandro Celaya authored
      e445b72d
  11. 21 Jun, 2023 2 commits
  13. 19 Jun, 2023 12 commits
  15. 16 Jun, 2023 1 commit
    • Robert Knight's avatar
      Add a note about a scenario where the thresholds will be inappropriate · 82b176d0
      Robert Knight authored 
      This function is used to scroll to the "nearest" highlight when clicking the
top/bottom buckets in the bucket bar. This can likely be reimplemented in a
simpler way in future that doesn't rely on knowing where the buckets are
relative to the viewport. If instead we assume that all the passed-in anchors
are off-screen, we could just scroll to the top/bottom one.
      82b176d0