- 16 Oct, 2015 11 commits
-
-
Robert Knight authored
Override the browser default styling on the search input's width property so that its maximum width will be limited by the available space in the top bar when expanded. Previously it was inflexible due to the browser default styling with the group name being pushed off the left side of the top bar as a result. There is still an issue at the moment in Firefox where the share icon gets covered by the search bar when expanded. T-90
-
Robert Knight authored
When the top-bar is used in the stream, the content needs to be centered above the stream's contents. T-90
-
Robert Knight authored
* Add a couple of missing titles * Fix hover state for share icon when groups is disabled T-90
-
Robert Knight authored
The input field has no padding by default so that it does not take up space when collapsed. When expanded we need some padding between the icon and the input.
-
Robert Knight authored
53bd01169cd8eb00748f953a6b2488f09637b32c incorrectly changed the '.annotator-no-transition' selector which disables the animated width transitions on the sidebar during manual resizes to '.annotator-frame .annotator-no-transition' which meant that it did not take effect. T-90
-
Robert Knight authored
T-90
-
Robert Knight authored
* Make the spacing between the top bar icons consistent * Remove redundant CSS from top-bar.scss The CSS usage here is a little ugly because .top-bar__btn is used inside the <simple-search> directive but at least it is clear where the style comes from.
-
Robert Knight authored
This adds updated icons which were designed together and line up correctly.
-
Robert Knight authored
Implement the design changes from https://trello.com/c/DZEDxU4C/90-top-bar-ui-updates - Move the 'My Annotations' item up and change the label to the account username - Swap Feedback and Help - Make the 'Sign out' link more subtle * BEM-ify the dropdown menu link CSS for consistency and to avoid specificity conflicts
-
Robert Knight authored
Following UX discussion: * Expand the search bar only on click rather than hover * Add missing title to search bar component
-
Robert Knight authored
* Adjust the styling of the icon so that the bottom of the 'chat heads' icon for groups is aligned vertically with the baseline of the group name label * Remove extra space between group name label and dropdown indicator arrow T-90
-
- 15 Oct, 2015 13 commits
-
-
Robert Knight authored
Increase top bar height to 40px to match the designs. A visual side effect is that the dropdown menus now overlap the top bar and clearly appear on top of it rather than just below.
-
Robert Knight authored
Position the arrow at the top of the groups list dropdown menu so that it appears beneath the dropdown indicator in the top-bar. This is done by hiding the dropdown menu's "built in" arrow created via CSS :before and :after pseudo-elements and introducing a separate element which uses the same technique with borders to create the dropdown arrow. The use of a separate element for the arrow allows it to be aligned with the right edge of the dropdown menu's parent element (in this case, the group name in the top bar) rather than the dropdown menu's content.
-
Robert Knight authored
* Set the inner container in the top bar to the full height of the top bar. This corrects the vertical alignment of the toolbar icons. * Remove the extraneous 'content' class from the top bar * Remove unused selectors for button styling T-90
-
Robert Knight authored
When the new top-bar design is enabled, collapse the search input unless the field is hovered, focused or there is an active search query. In the legacy top-bar design, the search field remains expanded all the time T-90
-
Robert Knight authored
Update the button styling for top bar icons to match the mocks. The icons have been changed to <a> rather than <button> tags to work around an issue I see in Firefox where the icon is initially clipped when loaded and then re-renders itself correctly on hover. This needs additional investigation.
-
Robert Knight authored
* Make the corners of the top bar straight * Remove the unnecessary border at the top of the sidebar, since the sidebar is already bordered by the bottom of the browser's address bar T-90
-
Robert Knight authored
Variables in calc() expressions must be interpolated.
-
Robert Knight authored
T-90
-
Robert Knight authored
T-90
-
Robert Knight authored
To simplify the process of updating the icon font and make sure that nothing is missed out, add a script which takes the icon font archive generated by icomoon and updates the relevant files in the repository. T-90
-
Robert Knight authored
When the groups feature is enabled, use the new top bar design from https://trello.com/c/DZEDxU4C/90-top-bar-ui-updates : [Group selector ] [Search][Sort][Share][Account] * Align the left/right edges of the top-bar content with the content below. * Use a placeholder icon for the account menu for the moment. It will be replaced with an appropriate SVG when available.
-
Nick Stenning authored
T90 top bar refactor
-
Robert Knight authored
In preparation for implementing the new top-bar design, extract it into its own directive. * Refactor the 'persona' filter into a simple function that returns a {username, provider} object which IMO makes for more straightforward code. Several of the test cases which deal with inputs not in that form were removed. If account IDs are not guaranteed to be in the 'acct:<username>@<provider>' form then we should be explicit about what is accepted and what is returned. T-90
-
- 14 Oct, 2015 7 commits
-
-
Robert Knight authored
For consistency use element directives for components and attribute directives only for directives that provide some enhancement to an existing UI T-90
-
Nick Stenning authored
T93 New 'Clear selection' button design
-
Nick Stenning authored
Sort groups server-side
-
Robert Knight authored
Following discussion on https://github.com/hypothesis/h/pull/2615 it looks like we can ship this for all users. T-93
-
Robert Knight authored
This provides a clearer design for the search status button. The new design is part of the groups roll-out and is only shown when the groups feature is enabled. T-93
-
Robert Knight authored
The groups are already sorted in a suitable order by the server, so they do not need to be sorted again on the client.
-
Robert Knight authored
In preparation for implementing a new design for the search/selection status bar, extract it into its own directive.
-
- 13 Oct, 2015 9 commits
-
-
Robert Knight authored
Don't endlessly re-request features on connectivity issues
-
Nick Stenning authored
If, for whatever reason, the request to fetch features data fails, simply retry a little later (with a randomised exponential backoff). This commit uses the [retry module](https://www.npmjs.com/package/retry) to provide the backoff logic. N.B. If we fail 10 times (over a period spanning between ~15 and ~30 minutes, using the defaults from the retry module) then we will simply stop looking for new features data. There's no point burning client CPU forever in the hope that the server reappears. Fixes #2547.
-
Nick Stenning authored
UI tweaks for the group creation form
-
Robert Knight authored
* Increase the spacing between the label and the group name * Disable focus outline for the group name field, since the input has no border * Disable autocomplete for the group name field, since we are prompting for a _new_ name
-
Nick Stenning authored
Convert Chrome extension to Browserify + CommonJS modules
-
Nick Stenning authored
Push notifications of group membership changes
-
Sean Hammond authored
Server-rendered accounts forms
-
Robert Knight authored
See linked description in GitHub issue. It is a bit silly that we are running the Chrome extension tests exclusively in PhantomJS rather than Chrome, but for the moment, get the existing tests to run using the same getOwnPropertyNames() shim that is used for the main client app tests.
-
Robert Knight authored
It is likely that we will want to handle these events differently in future, so split them into two separate tests.
-