- 30 Mar, 2020 1 commit
-
-
Kyle Keating authored
add `type-coercion.js` util with 4 methods. These are used on incoming the host-config values `openSidebar` and `requestConfigFromFrame` which may have an incompatible type upstream (via3) from what the client expects. - toInteger - toObject - toString - toBoolean These methods coerces specific values into types so that downstream (client) methods can make assumptions. This is part of the prep work to support via3 which will eventually only export strings values in the config.
-
- 27 Mar, 2020 9 commits
-
-
Robert Knight authored
Revert mocha to v7.0.1
-
Robert Knight authored
In mocha >= 7.1.0, exceptions thrown in test hooks (eg. a `beforeEach` hook) cause the tests to hang without printing any useful exception details. From my notes in a Slack investion: > The karma-mocha package is responsible for running mocha by calling > mocha.setup() before the test modules are evaluated and then mocha.run() > after they are evaluated to actually run the tests, as well as listening > for test events from Mocha’s “runner” and reporting them back to Karma. > When the beforeEach hook fails, the runner emits a “fail” event which > karma-mocha receives. karma-mocha then attempts to emit a “test end” > event and that ends up triggering an exception in a call to > test.retriedTest() in code which was added in > https://github.com/mochajs/mocha/pull/4181/files. Until this issue is resolved, pin mocha to a version that doesn't trigger this problem.
-
Lyza Gardner authored
Replace `annotation-thread` with preact `Thread` component
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Adjust CSS not contained within `Thread` to account for annotations displayed within nested threads.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Exclude src/test-util from code coverage metrics
-
Robert Knight authored
Our current policy is not to include test-only code in coverage metrics.
-
- 26 Mar, 2020 2 commits
-
-
Kyle Keating authored
Add preStart method to cross-origin-rcp module
-
Kyle Keating authored
When called, allows any incoming rpc request to wait in a queue and be proceeded a short time later when the actual start() method is called. This prevents potential timeouts from incoming RPC requests from LMS (or similar) that arrive after we tipped off the parent frame with a fetchConfig outgoing request but before startServer() is called. - Rename start() to startServer() - Use newer module export standard that matches the rest of the app
-
- 24 Mar, 2020 12 commits
-
-
Robert Knight authored
Remove $location service and annotation subcomponents from sidebar entry module
-
Lyza Gardner authored
Remove unused `permissions` service
-
Robert Knight authored
After `Annotation` was converted to Preact, the subcomponents no longer need to be wrapped and exposed to Angular.
-
Robert Knight authored
This built-in Angular service is no longer used, so remove the code to configure it and expose it to other services.
-
Lyza Danger Gardner authored
Use `permissions` util instead
-
Lyza Gardner authored
Replace angular `toastr` with preact-compatible toast messages
-
Robert Knight authored
Replace Angular router
-
Robert Knight authored
-
Robert Knight authored
Bump fetch-mock from 9.2.1 to 9.3.1
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
* preact-compatible * more accessible
-
Robert Knight authored
Fix an issue where the route was set before the initial profile and groups fetch had completed, which could result in the WebSocket connection being created and then immediately torn down and re-created on startup. The route was set too soon because Safari and Chrome emit a "popstate" event on page load, which triggered a call to `router.sync()` before the call to `sync()` made by `setupRoute` in src/sidebar/index.js after the initial profile and groups load. The solution is to only add the "popstate" listener after the initial call to `sync()`.
-
- 23 Mar, 2020 16 commits
-
-
Lyza Gardner authored
Remove legacy `annotation` component; rename `AnnotationOmega` -> `Annotation`
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Implement a replacement for the Angular JS router which will enable the root components of the app to be more easily migrated to Preact in future. Since the app only has three routes with very simple parameters, we don't yet need a fully-fledged router implementation but can get by with some pretty basic URL parsing. - Introduce a store module which holds the currently active route (`null`, "sidebar", "annotation" or "stream") and any parameters of that route. This state replaces the `isSidebar` boolean in the `viewer` module, since whether the app is the sidebar can be determined by checking the active route name. - Add a `router` service which handles synchronizing the store route with the current URL (via the `sync` method or in response to a `popstate` DOM event) or updating the URL and active route in the store (via the `navigate` method). - Modify the `<hypothesis-app>` component to fetch the active route from the store and use it to conditionally render the appropriate content component. This replaces the Angular router configuration that used to be in `src/sidebar/index.js` - Change the places that used to read or update the current route to read the active route and route params from the store (`store.{route, routeParams}`) and switch the current route by using the `router` service (`router.navigate`) - Remove the unused angular-route package Fixes #1878
-
Robert Knight authored
Fix spurious WebSocket disconnection errors
-
Robert Knight authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.2.1 to 9.3.1. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.2.1...v9.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Remove browserify-shim
-
Robert Knight authored
Revert "Bump prettier from 1.19.1 to 2.0.1"
-
Robert Knight authored
This reverts commit 5cb9041d.
-