- 16 Jan, 2017 5 commits
-
-
Robert Knight authored
Remove one layer of dir traversal after moving karma.config.js from src/scripts to src/sidebar.
-
Robert Knight authored
All of the templates are part of the sidebar application.
-
Robert Knight authored
Separate out the code for: - The sidebar application (now in src/sidebar) - The annotation layer and client bootstrap (now in src/annotator) - Code shared between the two (now in src/shared)
-
Sean Hammond authored
Simplify client source directory structure
-
Robert Knight authored
-
- 12 Jan, 2017 2 commits
-
-
Robert Knight authored
The previous location was a vestigate of when the client was part of the Hypothesis web service.
-
Robert Knight authored
The 'h/static' directory names are a vestigate from when the client was part of the Hypothesis web service.
-
- 10 Jan, 2017 7 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Update to latest version of dom-anchor-text-{quote, position} libs
-
Robert Knight authored
-
Robert Knight authored
Adapt to `toRange` returning null in 4.x rather than throwing an exception if the quote is not found and add a test case for quote anchoring failing. See https://github.com/tilgovi/dom-anchor-text-quote/issues/10
-
Robert Knight authored
This incorporates a fix for a bug in the new `fromRange()` function in IE/Edge which appeared in the 3.x series. See https://github.com/tilgovi/dom-anchor-text-position/issues/4
-
Robert Knight authored
This fixes several issues where creating a selector from a Range object could fail. * Update types.coffee to use the modified interfaces of the libraries which now export fromSelector() and toRange() functions rather than classes. * Update test expectations for the HTML anchoring tests as the updated dom-anchor-text-position library fixes a bug that caused most of the failures
-
- 09 Jan, 2017 1 commit
-
-
Sean Roberts authored
Remove initial redirect when sidebar loads
-
- 05 Jan, 2017 3 commits
-
-
Robert Knight authored
Avoid redirecting to '/viewer' when the sidebar loads. This redirect is unnecessary since the sidebar never changes its mode once loaded and it caused the viewer embedded on a page to fail to load when restoring a closed tab in Chrome. This may also resolve issues where the user agent disallows the 'replaceState' call in certain situations (search prod-client reports on Sentry for "replaceState") Fixes #178
-
Robert Knight authored
-
Robert Knight authored
-
- 23 Dec, 2016 4 commits
-
-
Robert Knight authored
Update tag service urls
-
Sean Roberts authored
Show annotations in Annotations tab but with quote struck through after anchoring timeout
-
chdorner authored
Since we're not linking to the stream anymore.
-
chdorner authored
-
- 22 Dec, 2016 1 commit
-
-
Robert Knight authored
Instead of marking annotations as orphans after the anchoring timeout expires, instead display them in the Annotations tab but with a visual indicator that they have not yet anchored. This avoids showing annotations that are still anchoring in the Orphans tab, which can be confusing when it happens in long PDF documents with many annotations. * Add an `$anchorTimeout` flag to annotations that is set if annotations fail to anchor within the timeout period. * Display annotations with this flag set in the Annotations tab, on the optimistic basis that they will eventually anchor. * When rendering annotations with this flag set, display them with a quote struck through (same as orphans) to indicate that they are pending. The visual representation of the pending state may be tweaked in future.
-
- 21 Dec, 2016 2 commits
-
-
Sean Roberts authored
Consolidate logic for annotation <-> tab assignment
-
Sean Roberts authored
Move the list of connected frames to the Redux store
-
- 20 Dec, 2016 1 commit
-
-
Robert Knight authored
Use a custom element name for highlight spans
-
- 19 Dec, 2016 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
Previously the logic for determining which tab an annotation should appear in occurred both in `root-thread.js` where it was used to filter annotations based on the selected tab, and in `widget-controller.js` where it was used to switch to the tab containing a particular annotation. Consolidate all the logic for deciding which tab an annotation should appear in into a single module. This makes it easier to test that tab assignment is correct with different combinations of feature flags and annotation states and to add additional logic in future.
-
Robert Knight authored
Move metadata about the frames that are connected to the sidebar app, such as the document's URL and fingerprint, to the central app state store. This is part of an effort to unify how important application state is managed.
-
- 16 Dec, 2016 2 commits
-
-
Robert Knight authored
Add HTML baseline tests
-
Robert Knight authored
Add a set of baseline tests for HTML anchoring which attempt to anchor a set of selectors for an annotation using data in the format returned by the Hypothesis API and then verify that the same selectors are generated when re-describing the anchored ranges.
-
- 30 Nov, 2016 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Remove 'defer_realtime_updates' feature flagging
-
- 28 Nov, 2016 2 commits
-
-
Nick Stenning authored
This is now enabled by for everyone, so we don't need the feature flag any more.
-
Robert Knight authored
When anchoring many annotations on a PDF, the text of the same page may be requested many times. The text is initially fetched via an async call to PDFViewerApplication.pdfViewer.getPageTextContent() and the result is then cached for future use. Previously the cache was only updated once this expensive call returned a result. Consequently when anchoring many annotations at once, there would be a lot of unnecessary cache misses and repeated calls to PDFViewerApplication.pdfViewer.getPageTextContent() Fix the problem by storing a promise for the result in the cache when the text for a given page is requested the first time. Consequently the text for each page will only be fetched once.
-
- 27 Nov, 2016 1 commit
-
-
Robert Knight authored
Use the same trick that was applied to the adder in d9644a80 to reduce the likelihood of the page's own CSS styling modifying the appearance of highlights. Compared to alternative methods which would raise the precedence of highlight styling (inline styles, !important !all !the !things, selector precedence hacks), this approach is simpler as it makes the conflicting rule from the page's own styling not apply at all. Fixes hypothesis/h#3520
-
- 18 Nov, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
- 17 Nov, 2016 1 commit
-
-
Robert Knight authored
Added links to help center from help panel
-