1. 19 Oct, 2015 3 commits
  2. 16 Oct, 2015 17 commits
  3. 15 Oct, 2015 16 commits
    • Robert Knight's avatar
      Increase top bar height to 40px · 37127a8c
      Robert Knight authored
      Increase top bar height to 40px to match the designs.
      A visual side effect is that the dropdown menus now
      overlap the top bar and clearly appear on top of it
      rather than just below.
      37127a8c
    • Robert Knight's avatar
      Adjust dropdown menu arrow location for groups list · be78fc2b
      Robert Knight authored
      Position the arrow at the top of the groups list
      dropdown menu so that it appears beneath the
      dropdown indicator in the top-bar.
      
      This is done by hiding the dropdown menu's "built in"
      arrow created via CSS :before and :after pseudo-elements
      and introducing a separate element which uses the same
      technique with borders to create the dropdown arrow.
      
      The use of a separate element for the arrow allows it
      to be aligned with the right edge of the dropdown menu's
      parent element (in this case, the group name in the top bar)
      rather than the dropdown menu's content.
      be78fc2b
    • Robert Knight's avatar
      Simplify styling of top-bar · 7a7c2510
      Robert Knight authored
       * Set the inner container in the top bar to the full height
         of the top bar.
      
         This corrects the vertical alignment of the toolbar icons.
      
       * Remove the extraneous 'content' class from the top bar
      
       * Remove unused selectors for button styling
      
      T-90
      7a7c2510
    • Robert Knight's avatar
      Collapse the search input when the search query is empty · 648dd657
      Robert Knight authored
      When the new top-bar design is enabled,
      collapse the search input unless the field is hovered,
      focused or there is an active search query.
      
      In the legacy top-bar design, the search field remains
      expanded all the time
      
      T-90
      648dd657
    • Robert Knight's avatar
      Merge pull request #2619 from hypothesis/explicit-settings-for-websocket · 4490b70c
      Robert Knight authored
      Explicit settings for websocket
      4490b70c
    • Nick Stenning's avatar
      Use websocket URL provided in settings · 8334e2f7
      Nick Stenning authored
      Rather than constructing a URL from hard-coded defaults in the streamer
      service, we pass the websocket URL from the backend in the settings
      object and use this when opening the websocket.
      8334e2f7
    • Nick Stenning's avatar
      Load API URL from a settings object, not a <link> tag · c1d03a03
      Nick Stenning authored
      The approach of embedding a link tag in the app.html doesn't really give
      us a great deal of flexibility. URLs within the application, perhaps as
      a result, tend to be created either from baseURI or from the API URL,
      called `serviceUrl` in the code.
      
      This commit leaves the <base> tag alone, but:
      
      - replaces the serviceUrl <link> tag with a settings object,
        `window.hypothesis.settings` which is inlined into app.html.
      - replaces the serviceUrl angular service with a generic settings
        service.
      - renames serviceUrl to apiUrl, to make its purpose more obvious.
      c1d03a03
    • Robert Knight's avatar
      Update button styling for top bar icons · d1ebd263
      Robert Knight authored
      Update the button styling for top bar icons to match
      the mocks.
      
      The icons have been changed to <a> rather than <button> tags
      to work around an issue I see in Firefox where the icon
      is initially clipped when loaded and then re-renders itself
      correctly on hover. This needs additional investigation.
      d1ebd263
    • Robert Knight's avatar
      Remove the rounded corners and top border from the sidebar · c36103ac
      Robert Knight authored
       * Make the corners of the top bar straight
      
       * Remove the unnecessary border at the top of the sidebar,
         since the sidebar is already bordered by the bottom
         of the browser's address bar
      
      T-90
      c36103ac
    • Robert Knight's avatar
      Correct padding at top of sidebar body · dd26f9ab
      Robert Knight authored
      Variables in calc() expressions must be interpolated.
      dd26f9ab
    • Robert Knight's avatar
      Use the new account icon in the top bar · 0582c1de
      Robert Knight authored
      T-90
      0582c1de
    • Robert Knight's avatar
    • Robert Knight's avatar
      Add a script to assist with updating the icon font · 2d8a89f3
      Robert Knight authored
      To simplify the process of updating the icon font and make
      sure that nothing is missed out, add a script which takes
      the icon font archive generated by icomoon and updates
      the relevant files in the repository.
      
      T-90
      2d8a89f3
    • Robert Knight's avatar
      Implement new layout of top bar when groups feature is enabled · c87110f5
      Robert Knight authored
      When the groups feature is enabled, use the new top bar design
      from https://trello.com/c/DZEDxU4C/90-top-bar-ui-updates :
      
       [Group selector    ] [Search][Sort][Share][Account]
      
       * Align the left/right edges of the top-bar content
         with the content below.
      
       * Use a placeholder icon for the account menu for the moment.
         It will be replaced with an appropriate SVG when available.
      c87110f5
    • Nick Stenning's avatar
      Merge pull request #2616 from robertknight/t90-top_bar_refactor · a3f7a2cc
      Nick Stenning authored
      T90 top bar refactor
      a3f7a2cc
    • Robert Knight's avatar
      Extract top bar component into own directive · 6f907ad2
      Robert Knight authored
      In preparation for implementing the new top-bar
      design, extract it into its own directive.
      
       * Refactor the 'persona' filter into a simple
         function that returns a {username, provider}
         object which IMO makes for more straightforward
         code.
      
         Several of the test cases which deal with inputs
         not in that form were removed.
      
         If account IDs are not guaranteed to be in
         the 'acct:<username>@<provider>' form then
         we should be explicit about what is accepted
         and what is returned.
      
      T-90
      6f907ad2
  4. 14 Oct, 2015 4 commits