• Robert Knight's avatar
    Refactor side-by-side state in Guest · 1475c104
    Robert Knight authored
    In issue discussions, tests and various parts of the code there are
    mentions of side-by-side mode being active or not. The `Guest` class
    didn't store this state directly but instead had a
    `closeSidebarOnDocumentClick` state which is always the inverse of
    "is side-by-side active?".
    
    Make the code easier to follow by storing the "is side-by-side active?" state
    directly. This will also avoid a misnamed variable if in future the
    state has other effects besides changing whether clicking on the
    document closes the sidebar.
    
     - Replace `closeSidebarOnDocumentClick` with a private
       `_sideBySideActive` property, exposed via a read-only
       `sideBySideActive` getter
    
     - Refactor tests to only use the public API of Guest (calling
       `Guest#fitSideBySide` or reading `sideBySideActive`)
    1475c104
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...