• Robert Knight's avatar
    Refactor side-by-side state in Guest · 1475c104
    Robert Knight authored
    In issue discussions, tests and various parts of the code there are
    mentions of side-by-side mode being active or not. The `Guest` class
    didn't store this state directly but instead had a
    `closeSidebarOnDocumentClick` state which is always the inverse of
    "is side-by-side active?".
    
    Make the code easier to follow by storing the "is side-by-side active?" state
    directly. This will also avoid a misnamed variable if in future the
    state has other effects besides changing whether clicking on the
    document closes the sidebar.
    
     - Replace `closeSidebarOnDocumentClick` with a private
       `_sideBySideActive` property, exposed via a read-only
       `sideBySideActive` getter
    
     - Refactor tests to only use the public API of Guest (calling
       `Guest#fitSideBySide` or reading `sideBySideActive`)
    1475c104
Name
Last commit
Last update
..
integration Loading commit data...
adder-test.js Loading commit data...
annotation-counts-test.js Loading commit data...
annotation-sync-test.js Loading commit data...
bucket-bar-test.js Loading commit data...
cross-frame-test.js Loading commit data...
empty.html Loading commit data...
features-test.js Loading commit data...
guest-test.js Loading commit data...
highlighter-test.js Loading commit data...
notebook-test.js Loading commit data...
range-util-test.js Loading commit data...
selection-observer-test.js Loading commit data...
sidebar-test.js Loading commit data...
sidebar-trigger-test.js Loading commit data...
toolbar-test.js Loading commit data...