• Robert Knight's avatar
    Refactor Guest#createAnnotation for readability · 5300b58c
    Robert Knight authored
    Convert the `createAnnotation` method of `Guest` to use async/await
    instead of manual chaining of Promise operations. This makes it easier
    to follow the logic and see that document metadata is assigned to the
    annotation before it is broadcast to other parts of the annotator in the
    `beforeAnnotationCreated` event. It also makes it easier to external
    code (eg. the tests) to determine when `createAnnotation` is "done" and
    has finished updating the annotation.
    
     - Convert `Guest#createAnnotation` to use async/await
    
     - Update tests for `createAnnotation` to await the returned Promise
       instead of a fixed timeout
    
     - Add a missing check in `createAnnotation` tests for the argument
       passed to the `beforeAnnotationCreated` event
    5300b58c
Name
Last commit
Last update
..
annotator Loading commit data...
boot Loading commit data...
images/icons Loading commit data...
shared Loading commit data...
sidebar Loading commit data...
styles Loading commit data...
test-util Loading commit data...
types Loading commit data...
.eslintrc Loading commit data...
karma.config.js Loading commit data...
tsconfig.json Loading commit data...