• Lyza Danger Gardner's avatar
    Add `!important` to two carefully-selected utility mixins · 6ee96180
    Lyza Danger Gardner authored
    This is the first time in my life I've ever found what seems like a
    potentially valid use case for `!important`: assuring that a utility
    class that establishes rhythm based on margins is able to do its job.
    
    Typically, our components should not be styling their own margins, but
    there are some cases where we do, e.g. the initial reset of button
    styles, which sets `margin: 0`. (Components should style their own
    padding, but margins are the domain of containing/parent elements).
    
    These two `!important` rules allow two utility mixins that are explicitly
    concerned with margins to trump the specificity of margin-resetting
    rules on descendent elements.
    
    See https://css-tricks.com/when-using-important-is-the-right-choice/
    6ee96180
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...