• Robert Knight's avatar
    Prevent side-by-side state getting out of sync between Guest and Integration · 79484cdd
    Robert Knight authored
    Both the `Guest` and `HTMLIntegration` maintained separate state for whether
    side-by-side mode was active or not. These states could get out of sync if the
    side-by-side feature flag was disabled when the guest first called
    `fitSideBySide` and then later enabled, as a result of the user logging into a
    different profile. In that case side-by-side would be enabled from the
    integration's perspective, but `Guest._sideBySideActive` would remain false.
    
    More generally this mismatch could occur in future if, for any reason, the
    integration decided to disable side-by-side outside of the context of a call to
    `fitSideBySide`.
    
    The result of this error was that clicking somewhere in the page would cause the
    sidebar to close, because the Guest thought that side-by-side was disabled, even
    though it was actually active.
    79484cdd
Name
Last commit
Last update
.github Loading commit data...
.yarn Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
.readthedocs.yaml Loading commit data...
.yarnrc.yml Loading commit data...
HACKING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.mjs Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
rollup-boot.config.mjs Loading commit data...
rollup-tests.config.mjs Loading commit data...
rollup.config.mjs Loading commit data...
tailwind-annotator.config.mjs Loading commit data...
tailwind-sidebar.config.mjs Loading commit data...
tailwind.config.mjs Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...