• Eduardo Sanz García's avatar
    Improve the logic that checks for iframe's document ready · 919e5bf1
    Eduardo Sanz García authored
    In certain situations, the logic to check when the iframe's document is
    ready didn't work as expected. The reason for that is that browsers
    create an initial blank document before the actual document loads.
    This blank document has a `readyState` of 'complete' in Safari and
    Chrome and of 'uninitialized' in Firefox. This blank document can be
    mistaken by the final document. I was able to reproduce a situation
    where the Hypothesis client was injected into the blank document. Then,
    the blank document was replaced by the actual document and the
    Hypothesis client was not not longer embedded.
    
    In addition, this commit:
    
    * renames `frame` to `iframe` (only in the test)
    * renames `_handledFrames` to _annotatableFrames`
    * removes `isAccessible` (no longer neede)
    919e5bf1
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...