• Robert Knight's avatar
    Remove `metadata` field from `HTMLMetadata` · a5c112a0
    Robert Knight authored
    The `HTMLMetadata` class provided two ways to get at the document
    metadata:
    
     1. A `getDocumentMetadata` method which reads the current metadata from
        the document and returns it
     2. A `metadata` field which returns the last-read metadata
    
    The `metadata` field was not used outside the tests and shouldn't be used
    because it might return stale metadata (in a web page with client-side
    JS that updates `<meta>` and `<link>` tags etc. after the page loads). This field
    was also used internally by the various helper methods that gather metadata,
    with non-obvious constraints on the order in which the helpers are called.
    
    Remove the field to prevent external mis-use of the class and make the data flow
    and dependencies clearer internally.
    a5c112a0
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...