• Robert Knight's avatar
    Limit VitalSource iframe height in PDFs · bfe0e9a7
    Robert Knight authored
    VitalSource PDF books currently create very tall iframes. When a user
    scrolls through a PDF page, they are scrolling the _parent_ frame rather
    than the iframe itself. The bucket bar and scrolling logic in the client
    don't support this. The result is that:
    
     - Bucket bar buckets are in the wrong location and don't scroll as the
       user scrolls the parent frame
     - Clicking on an annotation / bucket tries to scroll only the iframe,
       not the parent frame.
    
    To resolve this we need to do at least one of:
    
    1. Support these tall iframes in the client generally
    2. Forcibly change the height of the iframe and enable the iframe to scroll
    3. Persuade VitalSource to change the iframe layout so that the content frame
       scrolls, rather than the parent frame. They previously did this for EPUBs
       already.
    
    This commit implements a version of (2). If VS later apply (3) then we can
    remove this workaround.
    bfe0e9a7
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.mjs Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
requirements-dev.in Loading commit data...
rollup-boot.config.mjs Loading commit data...
rollup-tests.config.mjs Loading commit data...
rollup.config.mjs Loading commit data...
tailwind.config.mjs Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...