-
Sean Hammond authored
Cache the access token request promise, not just the access token itself. This commit fixes a problem that the client would send multiple concurrent access token requests if tokenGetter() was called multiple times before a response to any of the HTTP requests was received: 1. tokenGetter() is called, sends an HTTP request for the access token and returns a Promise for the access token from the request's response 2. Before the HTTP response is received tokenGetter() is called again, sends another HTTP request, returns another Promise. As soon as one access token response is received then tokenGetter() caches the access token and just returns it, doesn't send any more HTTP requests, but each time tokenGetter() is called *before the first access token response has been received* it sends another, concurrent access token request. It does not "know" that it already has an access token request in-flight. The fix is to cache the first access token request Promise when the first access token request is sent and then just keep returning that Promise, instead of sending more requests: Instead of caching the access token itself (`cachedToken`) we now cache a Promise for the access token (`accessTokenPromise`) the first time we send the access token request. Each further time that `tokenGetter()` is called, if it already has a `accessTokenPromise`, then it just returns the Promise and doesn't send another HTTP request. It now "knows" that it already has an access token request in-flight.
dbcb5881
Name |
Last commit
|
Last update |
---|---|---|
.github | ||
docs | ||
images | ||
scripts | ||
src | ||
.eslintignore | ||
.eslintrc | ||
.gitignore | ||
.npmignore | ||
.npmrc | ||
.travis.yml | ||
CHANGELOG.md | ||
CODE_OF_CONDUCT | ||
Jenkinsfile | ||
LICENSE | ||
Makefile | ||
README.md | ||
gulpfile.js | ||
npm-shrinkwrap.json | ||
package.json |