Remove elements created during test

src/annotator/integrations/test/html-test.js

@@ -77,13 +77,17 @@ describe('HTMLIntegration', () => {
       const highlight = document.createElement('div');
       document.body.appendChild(highlight);
 
-      const anchor = { highlights: [highlight] };
+      try {
+        const anchor = { highlights: [highlight] };
 
-      const integration = new HTMLIntegration();
-      await integration.scrollToAnchor(anchor);
+        const integration = new HTMLIntegration();
+        await integration.scrollToAnchor(anchor);
 
-      assert.calledOnce(fakeScrollIntoView);
-      assert.calledWith(fakeScrollIntoView, highlight, sinon.match.func);
+        assert.calledOnce(fakeScrollIntoView);
+        assert.calledWith(fakeScrollIntoView, highlight, sinon.match.func);
+      } finally {
+        highlight.remove();
+      }
     });
   });
 

src/annotator/integrations/test/pdf-test.js

@@ -104,6 +104,7 @@ describe('annotator/integrations/pdf', () => {
       pdfIntegration?.destroy();
       delete window.PDFViewerApplication;
       outerContainer.remove();
+      document.querySelector('hypothesis-banner')?.remove(); // <hypothesis-banner> elements are created outside the outerContainer
       $imports.$restore();
     });
 
@@ -288,11 +289,16 @@ describe('annotator/integrations/pdf', () => {
         pdfIntegration = createPDFIntegration();
 
         document.body.appendChild(anchor.highlights[0]);
-        await triggerUpdate();
 
-        assert.equal(anchor.highlights.length, 1);
-        assert.ok(anchor.range);
-        assert.notCalled(fakeAnnotator.anchor);
+        try {
+          await triggerUpdate();
+
+          assert.equal(anchor.highlights.length, 1);
+          assert.ok(anchor.range);
+          assert.notCalled(fakeAnnotator.anchor);
+        } finally {
+          anchor.highlights[0].remove();
+        }
       });
     });
 

src/annotator/test/sidebar-trigger-test.js

@@ -14,6 +14,11 @@ describe('sidebarTrigger', () => {
     document.body.appendChild(triggerEl2);
   });
 
+  afterEach(() => {
+    triggerEl1.remove();
+    triggerEl2.remove();
+  });
+
   it('calls the show callback which a trigger button is clicked', () => {
     const fakeShowFn = sinon.stub();
     sidebarTrigger(document, fakeShowFn);

src/sidebar/util/test/dom-test.js

@@ -11,6 +11,10 @@ describe('sidebar/util/dom', () => {
       document.body.appendChild(theElement);
     });
 
+    afterEach(() => {
+      theElement.remove();
+    });
+
     it("should return an element's height", () => {
       const testElement = document.getElementById('testElement');
       assert.equal(getElementHeightWithMargins(testElement), 450);