Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
052d6e86
Unverified
Commit
052d6e86
authored
Jan 22, 2020
by
Kyle Keating
Committed by
GitHub
Jan 22, 2020
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1707 from hypothesis/tag-css-fix
Minor change to tag-editor class names
parents
4e85644b
4162a791
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
tag-editor.js
src/sidebar/components/tag-editor.js
+2
-2
tag-editor-test.js
src/sidebar/components/test/tag-editor-test.js
+1
-1
tag-editor.scss
src/styles/sidebar/components/tag-editor.scss
+2
-2
No files found.
src/sidebar/components/tag-editor.js
View file @
052d6e86
...
@@ -183,14 +183,14 @@ function TagEditor({ onEditTags, tags: tagsService, tagList }) {
...
@@ -183,14 +183,14 @@ function TagEditor({ onEditTags, tags: tagsService, tagList }) {
return
(
return
(
<
section
className
=
"tag-editor"
>
<
section
className
=
"tag-editor"
>
<
ul
<
ul
className
=
"tag-editor__tag
-list
"
className
=
"tag-editor__tag
s
"
aria
-
label
=
"Suggested tags for annotation"
aria
-
label
=
"Suggested tags for annotation"
>
>
{
tagList
.
map
(
tag
=>
{
{
tagList
.
map
(
tag
=>
{
return
(
return
(
<
li
<
li
key
=
{
`
${
tag
}
`
}
key
=
{
`
${
tag
}
`
}
className
=
"tag-editor__
tag-
item"
className
=
"tag-editor__item"
aria
-
label
=
{
`Tag:
${
tag
}
`
}
aria
-
label
=
{
`Tag:
${
tag
}
`
}
>
>
<
span
className
=
"tag-editor__edit"
>
{
tag
}
<
/span
>
<
span
className
=
"tag-editor__edit"
>
{
tag
}
<
/span
>
...
...
src/sidebar/components/test/tag-editor-test.js
View file @
052d6e86
...
@@ -60,7 +60,7 @@ describe('TagEditor', function() {
...
@@ -60,7 +60,7 @@ describe('TagEditor', function() {
it
(
'adds appropriate tag values to the elements'
,
()
=>
{
it
(
'adds appropriate tag values to the elements'
,
()
=>
{
const
wrapper
=
createComponent
();
const
wrapper
=
createComponent
();
wrapper
.
find
(
'li'
).
forEach
((
tag
,
i
)
=>
{
wrapper
.
find
(
'li'
).
forEach
((
tag
,
i
)
=>
{
assert
.
isTrue
(
tag
.
hasClass
(
'tag-editor__
tag-
item'
));
assert
.
isTrue
(
tag
.
hasClass
(
'tag-editor__item'
));
assert
.
equal
(
tag
.
text
(),
fakeTags
[
i
]);
assert
.
equal
(
tag
.
text
(),
fakeTags
[
i
]);
assert
.
equal
(
tag
.
prop
(
'aria-label'
),
`Tag:
${
fakeTags
[
i
]}
`
);
assert
.
equal
(
tag
.
prop
(
'aria-label'
),
`Tag:
${
fakeTags
[
i
]}
`
);
});
});
...
...
src/styles/sidebar/components/tag-editor.scss
View file @
052d6e86
...
@@ -8,12 +8,12 @@
...
@@ -8,12 +8,12 @@
width
:
100%
;
width
:
100%
;
}
}
&
__tag
-list
{
&
__tag
s
{
display
:
flex
;
display
:
flex
;
flex-wrap
:
wrap
;
flex-wrap
:
wrap
;
}
}
&
__
tag-
item
{
&
__item
{
display
:
flex
;
display
:
flex
;
margin-right
:
0
.5em
;
margin-right
:
0
.5em
;
margin-bottom
:
0
.5em
;
margin-bottom
:
0
.5em
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment