Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
23a84ffa
Commit
23a84ffa
authored
Mar 16, 2021
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reword comment about optimistically set group ID
Reword this comment to try and make the intent of the code clearer.
parent
5445ad58
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
5 deletions
+7
-5
NotebookView.js
src/sidebar/components/NotebookView.js
+7
-5
No files found.
src/sidebar/components/NotebookView.js
View file @
23a84ffa
...
@@ -34,11 +34,13 @@ function NotebookView({ loadAnnotationsService }) {
...
@@ -34,11 +34,13 @@ function NotebookView({ loadAnnotationsService }) {
const
groupName
=
focusedGroup
?.
name
??
'…'
;
const
groupName
=
focusedGroup
?.
name
??
'…'
;
// Get the ID of the group to fetch annotations from. Once groups are fetched
// Get the ID of the group to fetch annotations from.
// this is the same as the focused group ID. In the case where the notebook
//
// is configured to open with a specific group we can start fetching annotations
// Once groups have been fetched and one has been focused, use its ID. If
// sooner, without waiting for the group fetch to complete, by falling back
// groups haven't been fetched yet but we know the ID of the group that is
// to the initially-configured group.
// likely to be focused (eg. because the notebook has been configured to
// display a particular group when launched), we can optimistically fetch
// annotations from that group.
const
groupId
=
focusedGroup
?.
id
||
store
.
directLinkedGroupId
();
const
groupId
=
focusedGroup
?.
id
||
store
.
directLinkedGroupId
();
const
lastPaginationPage
=
useRef
(
1
);
const
lastPaginationPage
=
useRef
(
1
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment