Commit 25d3aa48 authored by Robert Knight's avatar Robert Knight

Remove unused iframe attributes

 - Remove `seamless` attribute which has not been supported by major
   browsers for years [1]
 - Remove the `name="hyp_sidebar_frame"` attribute which is not
   referenced anywhere else in the code. I did find a couple of
   references to it in Google, but only in scripts written by Hypothesis
   team members which are not run regularly.

[1] https://caniuse.com/iframe-seamless
parent f2d50edc
...@@ -76,12 +76,10 @@ function createSidebarIframe(config) { ...@@ -76,12 +76,10 @@ function createSidebarIframe(config) {
const sidebarAppSrc = config.sidebarAppUrl + '#' + configParam; const sidebarAppSrc = config.sidebarAppUrl + '#' + configParam;
const sidebarFrame = document.createElement('iframe'); const sidebarFrame = document.createElement('iframe');
sidebarFrame.setAttribute('name', 'hyp_sidebar_frame');
// Enable media in annotations to be shown fullscreen // Enable media in annotations to be shown fullscreen
sidebarFrame.setAttribute('allowfullscreen', ''); sidebarFrame.setAttribute('allowfullscreen', '');
sidebarFrame.setAttribute('seamless', '');
sidebarFrame.src = sidebarAppSrc; sidebarFrame.src = sidebarAppSrc;
sidebarFrame.title = 'Hypothesis annotation viewer'; sidebarFrame.title = 'Hypothesis annotation viewer';
sidebarFrame.className = 'h-sidebar-iframe'; sidebarFrame.className = 'h-sidebar-iframe';
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment