Commit 2660ef5d authored by Robert Knight's avatar Robert Knight

Address CR feedback

 * Sort injected parameter names alphabetically for Angular
   services

 * Use imperative names for group events published on the 'user'
   NSQ topic

 * Avoid unnecessary dance with functools.partial() in streamer.py
   to pass the reader's topic to the message handler
parent 0690b1ac
...@@ -61,7 +61,7 @@ function sessionActions(options) { ...@@ -61,7 +61,7 @@ function sessionActions(options) {
* *
* @ngInject * @ngInject
*/ */
function session($document, $http, $resource, flash, $rootScope) { function session($document, $http, $resource, $rootScope, flash) {
// TODO: Move accounts data management (e.g. profile, edit_profile, // TODO: Move accounts data management (e.g. profile, edit_profile,
// disable_user, etc) into another module with another route. // disable_user, etc) into another module with another route.
var actions = sessionActions({ var actions = sessionActions({
......
...@@ -16,6 +16,7 @@ var socket; ...@@ -16,6 +16,7 @@ var socket;
* @param $websocket - angular-websocket constructor * @param $websocket - angular-websocket constructor
* @param annotationMapper - The local annotation store * @param annotationMapper - The local annotation store
* @param groups - The local groups store * @param groups - The local groups store
* @param session - Provides access to read and update the session state
* *
* @return An angular-websocket wrapper around the socket. * @return An angular-websocket wrapper around the socket.
*/ */
......
...@@ -34,7 +34,7 @@ describe('h:session', function () { ...@@ -34,7 +34,7 @@ describe('h:session', function () {
})); }));
beforeEach(mock.inject(function (_$httpBackend_, _session_, _$rootScope_) { beforeEach(mock.inject(function (_$httpBackend_, _$rootScope_, _session_) {
$httpBackend = _$httpBackend_; $httpBackend = _$httpBackend_;
session = _session_; session = _session_;
$rootScope = _$rootScope_; $rootScope = _$rootScope_;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment