Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
289ae894
Commit
289ae894
authored
Mar 19, 2020
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace usage of removed `store.isSidebar` selector
parent
affc79a9
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
streamer.js
src/sidebar/services/streamer.js
+1
-1
streamer-test.js
src/sidebar/services/test/streamer-test.js
+2
-2
No files found.
src/sidebar/services/streamer.js
View file @
289ae894
...
@@ -52,7 +52,7 @@ export default function Streamer(
...
@@ -52,7 +52,7 @@ export default function Streamer(
break
;
break
;
}
}
if
(
!
store
.
isSidebar
()
)
{
if
(
store
.
route
()
!==
'sidebar'
)
{
applyPendingUpdates
();
applyPendingUpdates
();
}
}
}
}
...
...
src/sidebar/services/test/streamer-test.js
View file @
289ae894
...
@@ -123,11 +123,11 @@ describe('Streamer', function() {
...
@@ -123,11 +123,11 @@ describe('Streamer', function() {
userid
:
'jim@hypothes.is'
,
userid
:
'jim@hypothes.is'
,
},
},
}),
}),
isSidebar
:
sinon
.
stub
().
returns
(
true
),
pendingUpdates
:
sinon
.
stub
().
returns
({}),
pendingUpdates
:
sinon
.
stub
().
returns
({}),
pendingDeletions
:
sinon
.
stub
().
returns
({}),
pendingDeletions
:
sinon
.
stub
().
returns
({}),
receiveRealTimeUpdates
:
sinon
.
stub
(),
receiveRealTimeUpdates
:
sinon
.
stub
(),
removeAnnotations
:
sinon
.
stub
(),
removeAnnotations
:
sinon
.
stub
(),
route
:
sinon
.
stub
().
returns
(
'sidebar'
),
};
};
fakeGroups
=
{
fakeGroups
=
{
...
@@ -275,7 +275,7 @@ describe('Streamer', function() {
...
@@ -275,7 +275,7 @@ describe('Streamer', function() {
context
(
'when the app is the stream'
,
function
()
{
context
(
'when the app is the stream'
,
function
()
{
beforeEach
(
function
()
{
beforeEach
(
function
()
{
fakeStore
.
isSidebar
.
returns
(
false
);
fakeStore
.
route
.
returns
(
'stream'
);
});
});
it
(
'applies updates immediately'
,
function
()
{
it
(
'applies updates immediately'
,
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment