Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
2e26f163
Commit
2e26f163
authored
Mar 22, 2022
by
Lyza Danger Gardner
Committed by
Lyza Gardner
Mar 23, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix JSDoc typing for `useCallback`-wrapped callbacks
parent
5370c39d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
12 deletions
+15
-12
AnnotationEditor.js
src/sidebar/components/Annotation/AnnotationEditor.js
+15
-12
No files found.
src/sidebar/components/Annotation/AnnotationEditor.js
View file @
2e26f163
...
@@ -57,19 +57,21 @@ function AnnotationEditor({
...
@@ -57,19 +57,21 @@ function AnnotationEditor({
const
isEmpty
=
!
text
&&
!
tags
.
length
;
const
isEmpty
=
!
text
&&
!
tags
.
length
;
const
onEditTags
=
useCallback
(
const
onEditTags
=
useCallback
(
/** @param {string[]} tags */
tags
=>
{
tags
=>
{
store
.
createDraft
(
draft
.
annotation
,
{
...
draft
,
tags
});
store
.
createDraft
(
draft
.
annotation
,
{
...
draft
,
tags
});
},
},
[
draft
,
store
]
[
draft
,
store
]
);
);
/**
* Verify `newTag` has content and is not a duplicate; add the tag
*
* @param {string} newTag
* @return {boolean} - `true` if tag is added
*/
const
onAddTag
=
useCallback
(
const
onAddTag
=
useCallback
(
/**
* Verify `newTag` has content and is not a duplicate; add the tag
*
* @param {string} newTag
* @return {boolean} Tag was added to the draft's tags; `false` if duplicate
* or empty
*/
newTag
=>
{
newTag
=>
{
if
(
!
newTag
||
tags
.
indexOf
(
newTag
)
>=
0
)
{
if
(
!
newTag
||
tags
.
indexOf
(
newTag
)
>=
0
)
{
// don't add empty or duplicate tags
// don't add empty or duplicate tags
...
@@ -84,13 +86,13 @@ function AnnotationEditor({
...
@@ -84,13 +86,13 @@ function AnnotationEditor({
[
onEditTags
,
tags
,
tagsService
]
[
onEditTags
,
tags
,
tagsService
]
);
);
/**
* Remove a tag from the annotation.
*
* @param {string} tag
* @return {boolean} - `true` if tag extant and removed
*/
const
onRemoveTag
=
useCallback
(
const
onRemoveTag
=
useCallback
(
/**
* Remove tag from draft if present.
*
* @param {string} tag
* @return {boolean} Tag removed from draft
*/
tag
=>
{
tag
=>
{
const
newTagList
=
[...
tags
];
// make a copy
const
newTagList
=
[...
tags
];
// make a copy
const
index
=
newTagList
.
indexOf
(
tag
);
const
index
=
newTagList
.
indexOf
(
tag
);
...
@@ -115,6 +117,7 @@ function AnnotationEditor({
...
@@ -115,6 +117,7 @@ function AnnotationEditor({
* @param {boolean} isPrivate
* @param {boolean} isPrivate
*/
*/
const
onSetPrivate
=
useCallback
(
const
onSetPrivate
=
useCallback
(
/** @param {boolean} isPrivate */
isPrivate
=>
{
isPrivate
=>
{
store
.
createDraft
(
annotation
,
{
store
.
createDraft
(
annotation
,
{
...
draft
,
...
draft
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment