Merge pull request #2122 from hypothesis/remove-user-changed-event

Remove unused `USER_CHANGED` event

src/sidebar/events.js

@@ -5,8 +5,6 @@
 export default {
   // Session state changes
 
-  /** The logged-in user changed */
-  USER_CHANGED: 'userChanged',
   /**
    * API tokens were fetched and saved to local storage by another client
    * instance.

src/sidebar/services/session.js

@@ -113,10 +113,6 @@ export default function session(
     lastLoadTime = Date.now();
 
     if (userChanged) {
-      $rootScope.$broadcast(events.USER_CHANGED, {
-        profile: model,
-      });
-
       // Associate error reports with the current user in Sentry.
       if (model.userid) {
         sentry.setUserInfo({

src/sidebar/services/test/session-test.js

@@ -198,15 +198,6 @@ describe('sidebar/services/session', function () {
   });
 
   describe('#update()', function () {
-    it('broadcasts USER_CHANGED when the user changes', function () {
-      const userChangeCallback = sinon.stub();
-      $rootScope.$on(events.USER_CHANGED, userChangeCallback);
-      session.update({
-        userid: 'fred',
-      });
-      assert.calledOnce(userChangeCallback);
-    });
-
     it('updates the user ID for Sentry error reports', function () {
       session.update({
         userid: 'anne',