Tweaks from design review comments

* Use the correct 15px font size for the install button label and link input field * Make the mobile nav menu background full-width on mobile and indent open sub-menus * Use regular rather than light font weight for news item snippets

Tweaks from design review comments
* Use the correct 15px font size for the install button label and link input field * Make the mobile nav menu background full-width on mobile and indent open sub-menus * Use regular rather than light font weight for news item snippets
326da00c · Robert Knight · Nick Stenning · 1d1a2f35 · 326da00c · 326da00c
Commit 326da00c authored Dec 08, 2015 by Robert Knight Committed by Nick Stenning Dec 11, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 18 additions and 4 deletions

header.scss h/static/styles/header.scss +8 -1

home.scss h/static/styles/home.scss +10 -3

No files found.
--- a/h/static/styles/header.scss
+++ b/h/static/styles/header.scss
@@ -174,6 +174,11 @@
      margin-top: 10px;
      max-height: 0px;
      transition: max-height $anim-duration-normal ease-in;
+
+      // make the nav bar occupy the full width of the page when
+      // opened
+      margin-left: - $layout-h-margin;
+      margin-right: - $layout-h-margin;
    }

    .nav-bar-container.is-open {
@@ -182,6 +187,8 @@
      // the container grows in height at roughly the same speed as the
      // menu content slides down
      max-height: 400px;
+      border-top: 1px solid $color-alto;
+      border-bottom: 1px solid $color-alto;
    }

    .nav-bar {
@@ -220,7 +227,7 @@
      position: relative;

      border: none;
-      padding-left: 0px;
+      padding-left: 40px;
      padding-bottom: 10px;
    }


--- a/h/static/styles/home.scss
+++ b/h/static/styles/home.scss
 @at-root {
  .home__content {
+    // use new Sans Serif font on the homepage and larger line-spacing.
+    // We'll likely want to move this up to <body> in future once
+    // other pages on the site have been updated to a new design
    font-family: $font-family-site-sans;
+    line-height: $line-height-tall;
+
    color: $gray-darker;
    margin-top: 95px;
  }
@@ -87,8 +92,8 @@
  }

  .install-btn__icon {
-    width: 22px;
-    height: 22px;
+    width: 20px;
+    height: 20px;
    margin-right: 5px;
  }

@@ -105,6 +110,7 @@
    padding-right: 7px;
    padding-top: 5px;
    padding-bottom: 5px;
+    font-size: $font-size-body2;
  }

  .install-btn.is-hidden {
@@ -140,6 +146,7 @@

  .proxy-link-form {
    display: flex;
+    font-size: $font-size-body2;
  }

  .proxy-link-form__field {
@@ -212,7 +219,7 @@

  .news-item__snippet {
    font-size: $font-size-heading2;
-    font-weight: $font-weight-light;
+    line-height: $line-height-tall;
  }

  .news-more-link {