Handle invalid URIs gracefully in document domain extraction

Since h has very liberal URI parsing compared to the browser's URL
constructor, as well as some completely invalid data on old annotations,
the client needs to handle errors parsing annotation `uri` values.

Surprisingly `annotation-metadata.js` is the only place I found in the
client that attempts to do this, everywhere else is just using the `uri`
field as a string.

Fixes https://github.com/hypothesis/client/issues/3666

src/sidebar/helpers/annotation-metadata.js

@@ -6,25 +6,34 @@
 /** @typedef {import('../../types/api').TextPositionSelector} TextPositionSelector */
 /** @typedef {import('../../types/api').TextQuoteSelector} TextQuoteSelector */
 
-/** Extract a URI, domain and title from the given domain model object.
+/**
+ * Extract document metadata from an annotation.
  *
  * @param {Annotation} annotation
- *
  */
 export function documentMetadata(annotation) {
   const uri = annotation.uri;
 
-  let domain = new URL(uri).hostname;
-  let title = domain;
-
-  if (annotation.document && annotation.document.title) {
-    title = annotation.document.title[0];
+  let domain;
+  try {
+    domain = new URL(uri).hostname;
+  } catch {
+    // Annotation URI parsing on the backend is very liberal compared to the URL
+    // constructor. There is also some historic invalid data in h (eg [1]).
+    // Hence we must handle URL parsing failures in the client.
+    //
+    // [1] https://github.com/hypothesis/client/issues/3666
+    domain = '';
   }
-
   if (domain === 'localhost') {
     domain = '';
   }
 
+  let title = domain;
+  if (annotation.document && annotation.document.title) {
+    title = annotation.document.title[0];
+  }
+
   return {
     uri,
     domain,

src/sidebar/helpers/test/annotation-metadata-test.js

@@ -51,6 +51,14 @@ describe('sidebar/helpers/annotation-metadata', () => {
           assert.equal(documentMetadata(annotation).title, 'example.com');
         });
       });
+
+      ['http://localhost:5000', '[not a URL]'].forEach(uri => {
+        it('returns empty domain if URL is invalid or private', () => {
+          const annotation = fakeAnnotation({ uri });
+          const { domain } = documentMetadata(annotation);
+          assert.equal(domain, '');
+        });
+      });
     });
 
     context('when the annotation does not have a document property', () => {