Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
445bfef7
Commit
445bfef7
authored
Nov 04, 2022
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add tests to clarify what is expected if CFIs or URLs match but not both
parent
5cb7fb17
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
0 deletions
+20
-0
annotation-segment-test.js
src/sidebar/helpers/test/annotation-segment-test.js
+20
-0
No files found.
src/sidebar/helpers/test/annotation-segment-test.js
View file @
445bfef7
...
@@ -64,6 +64,26 @@ describe('annotationMatchesSegment', () => {
...
@@ -64,6 +64,26 @@ describe('annotationMatchesSegment', () => {
selector
:
{
type
:
'EPUBContentSelector'
,
url
:
'/chapters/04.xhtml'
},
selector
:
{
type
:
'EPUBContentSelector'
,
url
:
'/chapters/04.xhtml'
},
expected
:
false
,
expected
:
false
,
},
},
// CFIs do not match but URLs do. The successful match wins.
{
segment
:
{
cfi
:
'/2'
,
url
:
'/chapters/02.xhtml'
},
selector
:
{
type
:
'EPUBContentSelector'
,
cfi
:
'/4'
,
url
:
'/chapters/02.xhtml'
,
},
expected
:
true
,
},
// CFIs match but URLs do not. The successful match wins.
{
segment
:
{
cfi
:
'/2'
,
url
:
'/chapters/03.xhtml'
},
selector
:
{
type
:
'EPUBContentSelector'
,
cfi
:
'/2'
,
url
:
'/chapters/02.xhtml'
,
},
expected
:
true
,
},
].
forEach
(({
segment
,
selector
,
expected
},
index
)
=>
{
].
forEach
(({
segment
,
selector
,
expected
},
index
)
=>
{
it
(
`returns true if CFI or URL matches current segment (
${
index
}
)`
,
()
=>
{
it
(
`returns true if CFI or URL matches current segment (
${
index
}
)`
,
()
=>
{
const
ann
=
{
target
:
[{
selector
:
[
selector
]
}]
};
const
ann
=
{
target
:
[{
selector
:
[
selector
]
}]
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment