Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
481921fb
Commit
481921fb
authored
Sep 16, 2014
by
Randall Leeds
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix isHighlight and isComment logic
I acted too quickly on these edits. I can squash them up.
parent
d30d7b72
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
3 deletions
+4
-3
annotation.coffee
h/static/scripts/directives/annotation.coffee
+4
-3
No files found.
h/static/scripts/directives/annotation.coffee
View file @
481921fb
...
...
@@ -58,7 +58,7 @@ AnnotationController = [
# @returns {boolean} True if the annotation is a comment.
###
this.isComment = ->
not (model.target
.length or model.references
)
not (model.target
?.length or model.references?.length
)
###
*
# @ngdoc method
...
...
@@ -66,7 +66,8 @@ AnnotationController = [
# @returns {boolean} True if the annotation is a highlight.
###
this.isHighlight = ->
not (model.text or model.deleted or model.tags.length)
model.target?.length and not model.references?.length and
not (model.text or model.deleted or model.tags?.length)
###
*
# @ngdoc method
...
...
@@ -219,7 +220,7 @@ AnnotationController = [
this.render()
# Start editing brand new annotations immediately
unless model.id? or
this.isHighlight(
) then this.edit()
unless model.id? or
(highlight and this.isHighlight()
) then this.edit()
this
]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment