Skip to content

C
coopwire-hypothesis
Unverified Commit 518578a9 authored by Robert Knight's avatar Robert Knight Committed by GitHub
Browse files
Options

Merge pull request #1467 from hypothesis/tab-a11y 

Improve tab bar accessibility
parents b0cd5378 e645e66c
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
src/sidebar/components/selection-tabs.js
View file @ 518578a9
...@@ -29,6 +29,9 @@ function Tab({ ...@@ -29,6 +29,9 @@ function Tab({
})} })}
onMouseDown={onChangeTab.bind(this, type)} onMouseDown={onChangeTab.bind(this, type)}
onTouchStart={onChangeTab.bind(this, type)} onTouchStart={onChangeTab.bind(this, type)}
role="tab"
tabIndex="0"
aria-selected={selected}
> >
{children} {children}
{count > 0 && !isWaitingToAnchor && ( {count > 0 && !isWaitingToAnchor && (
...@@ -108,6 +111,7 @@ function SelectionTabs({ isLoading, settings, session }) { ...@@ -108,6 +111,7 @@ function SelectionTabs({ isLoading, settings, session }) {
className={classnames('selection-tabs', { className={classnames('selection-tabs', {
'selection-tabs--theme-clean': isThemeClean, 'selection-tabs--theme-clean': isThemeClean,
})} })}
role="tablist"
> >
<Tab <Tab
count={annotationCount} count={annotationCount}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment