Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
534c61e2
Commit
534c61e2
authored
Mar 13, 2017
by
Sean Hammond
Committed by
GitHub
Mar 13, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #278 from hypothesis/fix-on-pages-that-define-self
Fix client failing to load on pages that define `self`
parents
d99b094f
362b4edf
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
2 deletions
+4
-2
create-bundle.js
scripts/gulp/create-bundle.js
+4
-2
No files found.
scripts/gulp/create-bundle.js
View file @
534c61e2
...
@@ -94,9 +94,11 @@ module.exports = function createBundle(config, buildOpts) {
...
@@ -94,9 +94,11 @@ module.exports = function createBundle(config, buildOpts) {
// the `global`, `self` and `window` globals in that order.
// the `global`, `self` and `window` globals in that order.
//
//
// This can break on web pages which provide their own definition of
// This can break on web pages which provide their own definition of
// `global`. See https://github.com/hypothesis/h/issues/2723
// `global` or `self` that is not an alias for `window`. See
// https://github.com/hypothesis/h/issues/2723 and
// https://github.com/hypothesis/client/issues/277
global
:
function
()
{
global
:
function
()
{
return
'
typeof self !== "undefined" ? self :
window'
;
return
'window'
;
},
},
},
},
};
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment