Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
64fc388f
Unverified
Commit
64fc388f
authored
Jul 29, 2019
by
Robert Knight
Committed by
GitHub
Jul 29, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1271 from hypothesis/fix-new-note-btn-typo
Fix typo `bnt` -> `btn` in `SelectionTabs` component
parents
21ecaa76
ffd098d7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
selection-tabs.js
src/sidebar/components/selection-tabs.js
+2
-2
selection-tabs-test.js
src/sidebar/components/test/selection-tabs-test.js
+1
-1
No files found.
src/sidebar/components/selection-tabs.js
View file @
64fc388f
...
@@ -5,7 +5,7 @@ const propTypes = require('prop-types');
...
@@ -5,7 +5,7 @@ const propTypes = require('prop-types');
const
{
createElement
}
=
require
(
'preact'
);
const
{
createElement
}
=
require
(
'preact'
);
const
{
Fragment
}
=
require
(
'preact'
);
const
{
Fragment
}
=
require
(
'preact'
);
const
NewNoteB
nt
=
require
(
'./new-note-btn'
);
const
NewNoteB
tn
=
require
(
'./new-note-btn'
);
const
sessionUtil
=
require
(
'../util/session-util'
);
const
sessionUtil
=
require
(
'../util/session-util'
);
const
uiConstants
=
require
(
'../ui-constants'
);
const
uiConstants
=
require
(
'../ui-constants'
);
const
useStore
=
require
(
'../store/use-store'
);
const
useStore
=
require
(
'../store/use-store'
);
...
@@ -140,7 +140,7 @@ function SelectionTabs({ isLoading, settings, session }) {
...
@@ -140,7 +140,7 @@ function SelectionTabs({ isLoading, settings, session }) {
)}
)}
<
/div
>
<
/div
>
{
selectedTab
===
uiConstants
.
TAB_NOTES
&&
{
selectedTab
===
uiConstants
.
TAB_NOTES
&&
settings
.
enableExperimentalNewNoteButton
&&
<
NewNoteB
nt
/>
}
settings
.
enableExperimentalNewNoteButton
&&
<
NewNoteB
tn
/>
}
{
!
isLoading
&&
(
{
!
isLoading
&&
(
<
div
className
=
"selection-tabs__empty-message"
>
<
div
className
=
"selection-tabs__empty-message"
>
{
showNotesUnavailableMessage
&&
(
{
showNotesUnavailableMessage
&&
(
...
...
src/sidebar/components/test/selection-tabs-test.js
View file @
64fc388f
...
@@ -133,7 +133,7 @@ describe('SelectionTabs', function() {
...
@@ -133,7 +133,7 @@ describe('SelectionTabs', function() {
assert
.
isFalse
(
wrapper
.
exists
(
'.selection-tabs--theme-clean'
));
assert
.
isFalse
(
wrapper
.
exists
(
'.selection-tabs--theme-clean'
));
});
});
it
(
'should not display the new-note-b
nt
when the annotations tab is active'
,
function
()
{
it
(
'should not display the new-note-b
tn
when the annotations tab is active'
,
function
()
{
const
wrapper
=
createComponent
();
const
wrapper
=
createComponent
();
assert
.
equal
(
wrapper
.
find
(
NewNoteBtn
).
length
,
0
);
assert
.
equal
(
wrapper
.
find
(
NewNoteBtn
).
length
,
0
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment