Commit 6de1f58a authored by Lyza Danger Gardner's avatar Lyza Danger Gardner Committed by Lyza Gardner

Add `!important` padding rule to apply when input is focused.

The search input is visible when:

* The component's internal logic determines that it is expanded
* The component's input element receives focus

The last visual-regression fix addressed the first state, but not the
second. This commit adds an additional !important padding rule that is
applied when the input is focused, assuring that it has padding when
either expanded OR focused.
parent 05298fb7
...@@ -164,11 +164,14 @@ export default function SearchInput({ ...@@ -164,11 +164,14 @@ export default function SearchInput({
// Make the 0-padding rule `!important` so that it doesn't get // Make the 0-padding rule `!important` so that it doesn't get
// superseded by `Input` padding // superseded by `Input` padding
'max-w-0 !p-0': !isExpanded, 'max-w-0 !p-0': !isExpanded,
// However, if the input it focused, it is visually expanded, and
// needs that padding back
'focus:!p-1.5': true,
// Make the input have dimensions and padding when focused or // Make the input have dimensions and padding when focused or
// expanded. The left-margin is to make room for the focus ring of // expanded. The left-margin is to make room for the focus ring of
// the search icon-button when navigating by keyboard. Set a // the search icon-button when navigating by keyboard. Set a
// max-width to allow transition to work when exact width is unknown. // max-width to allow transition to work when exact width is unknown.
'focus:max-w-[150px] focus:p-1.5 focus:ml-[2px]': true, 'focus:max-w-[150px] focus:ml-[2px]': true,
'max-w-[150px] p-1.5 ml-[2px]': isExpanded, 'max-w-[150px] p-1.5 ml-[2px]': isExpanded,
}, },
'transition-[max-width] duration-300 ease-out' 'transition-[max-width] duration-300 ease-out'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment