Add lint check for semicolon usage

For stylistic consistency, require semicolons rather than relying on
ASI.

.eslintrc

@@ -19,10 +19,14 @@
       "error",
       { allow: ["warn", "error"] },
     ],
+    "no-self-compare": "error",
+    "no-throw-literal": "error",
+    "no-unused-expressions": "error",
     "no-use-before-define": [
       "error",
       {"functions": false},
     ],
+    "semi": "error",
     "strict": ["error", "safe"],
   },
   "parserOptions": {

h/static/scripts/directive/publish-annotation-btn.js

@@ -16,15 +16,15 @@ module.exports = function () {
 
       this.publishDestination = function () {
         return this.isShared ? this.group.name : this.privateLabel;
-      }
+      };
 
       this.groupType = function () {
         return this.group.public ? 'public' : 'group';
-      }
+      };
 
       this.setPrivacy = function (level) {
         this.onSetPrivacy({level: level});
-      }
+      };
     },
     controllerAs: 'vm',
     restrict: 'E',
@@ -38,4 +38,4 @@ module.exports = function () {
     },
     template: require('../../../templates/client/publish_annotation_btn.html'),
   };
-}
+};

h/static/scripts/directive/test/publish-annotation-btn-test.js

@@ -57,7 +57,7 @@ describe('publishAnnotationBtn', function () {
         type: 'group'
       },
       isShared: true
-    })
+    });
     var buttons = element.find('button');
     assert.equal(buttons[0].innerHTML, 'Post to Research Lab');
   });

h/static/scripts/directive/test/window-scroll-test.js

@@ -101,7 +101,7 @@ describe('windowScroll', function () {
         assert.calledOnce(callback);
 
         view.scrollY = 1800;
-        handler()
+        handler();
         assert.calledTwice(callback);
       });
     });