Commit 83dfa90a authored by Robert Knight's avatar Robert Knight

Remove unused `children` prop from `MenuItem`

The `MenuItem` component never used this prop. It was passed by mistake
in `SortMenu` as a duplicate of the `label` prop.
parent b7eec241
...@@ -45,7 +45,6 @@ import Slider from './slider'; ...@@ -45,7 +45,6 @@ import Slider from './slider';
* Contents of the submenu for this item. This is typically a list of `MenuItem` components * Contents of the submenu for this item. This is typically a list of `MenuItem` components
* with the `isSubmenuItem` prop set to `true`, but can include other content as well. * with the `isSubmenuItem` prop set to `true`, but can include other content as well.
* The submenu is only rendered if `isSubmenuVisible` is `true`. * The submenu is only rendered if `isSubmenuVisible` is `true`.
* @prop {Object} [children] - The content of the menu item.
*/ */
/** /**
...@@ -248,5 +247,4 @@ MenuItem.propTypes = { ...@@ -248,5 +247,4 @@ MenuItem.propTypes = {
onClick: propTypes.func, onClick: propTypes.func,
onToggleSubmenu: propTypes.func, onToggleSubmenu: propTypes.func,
submenu: propTypes.any, submenu: propTypes.any,
children: propTypes.object,
}; };
...@@ -26,9 +26,7 @@ export default function SortMenu() { ...@@ -26,9 +26,7 @@ export default function SortMenu() {
label={sortOption} label={sortOption}
onClick={() => actions.setSortKey(sortOption)} onClick={() => actions.setSortKey(sortOption)}
isSelected={sortOption === sortKey} isSelected={sortOption === sortKey}
> />
{sortOption}
</MenuItem>
); );
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment