Merge pull request #1399 from hypothesis/fix-double-build

Don't built the client a second time when running "npm publish"

Jenkinsfile

@@ -157,13 +157,8 @@ stage('Publish') {
                 // Publish the updated package to the npm registry.
                 // Use `npm` rather than `yarn` for publishing.
                 // See https://github.com/yarnpkg/yarn/pull/3391.
-                //
-                // `npm publish` currently re-builds the client, so `SIDEBAR_APP_URL` must be set.
                 sh "echo '//registry.npmjs.org/:_authToken=${env.NPM_TOKEN}' >> \$HOME/.npmrc"
-                sh """
-                export SIDEBAR_APP_URL=https://hypothes.is/app.html
-                npm publish --tag ${npmTag}
-                """
+                sh "npm publish --tag ${npmTag}"
                 sh "scripts/wait-for-npm-release.sh ${npmTag}"
 
                 // Deploy the client to cdn.hypothes.is, where the embedded

package.json

@@ -155,7 +155,6 @@
     "format": "prettier --list-different --write '**/*.{js,scss}'",
     "test": "gulp test",
     "report-coverage": "codecov -f coverage/coverage-final.json",
-    "version": "make clean build/manifest.json",
-    "prepublishOnly": "make clean build/manifest.json"
+    "version": "make clean build/manifest.json"
   }
 }