Merge pull request #1562 from hypothesis/remove-client-version-header-from-static-api-requests

Remove Hypothesis-Client-Version header from "trivial" API requests

src/sidebar/services/api-routes.js

@@ -14,12 +14,11 @@ function apiRoutes(settings) {
   let linkCache;
 
   function getJSON(url) {
-    const config = {
-      headers: {
-        'Hypothesis-Client-Version': '__VERSION__', // replaced by versionify
-      },
-    };
-    return fetch(url, config).then(response => {
+    // nb. The `/api/` and `/api/links` routes are fetched without specifying
+    // any additional headers/config so that we can use `<link rel="preload">` in
+    // the `/app.html` response to fetch them early, while the client JS app
+    // is loading.
+    return fetch(url).then(response => {
       if (response.status !== 200) {
         throw new Error(`Fetching ${url} failed`);
       }

src/sidebar/services/test/api-routes-test.js

@@ -91,14 +91,6 @@ describe('sidebar.api-routes', () => {
         assert.deepEqual(routes, apiIndexResponse.links);
       });
     });
-
-    it('sends client version custom request header', () => {
-      return apiRoutes.routes().then(() => {
-        assert.calledWith(window.fetch, fakeSettings.apiUrl, {
-          headers: { 'Hypothesis-Client-Version': '__VERSION__' },
-        });
-      });
-    });
   });
 
   describe('#links', () => {