Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
93590fd6
Commit
93590fd6
authored
Sep 17, 2014
by
gergely-ujvari
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1506 from hypothesis/1502-missing-uri-property
Sync the bridge after beforeAnnotationCreated
parents
90d6d705
30bd605d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
7 deletions
+6
-7
annotation.coffee
h/static/scripts/directives/annotation.coffee
+1
-1
guest.coffee
h/static/scripts/guest.coffee
+5
-0
annotation-test.coffee
tests/js/directives/annotation-test.coffee
+0
-6
No files found.
h/static/scripts/directives/annotation.coffee
View file @
93590fd6
...
@@ -188,7 +188,7 @@ AnnotationController = [
...
@@ -188,7 +188,7 @@ AnnotationController = [
angular.extend @annotation, angular.copy model
angular.extend @annotation, angular.copy model
# Extract the document metadata.
# Extract the document metadata.
if model.document
and model.target.length
if model.document
domain = extractURIComponent(model.uri, 'hostname')
domain = extractURIComponent(model.uri, 'hostname')
@document =
@document =
...
...
h/static/scripts/guest.coffee
View file @
93590fd6
...
@@ -226,6 +226,11 @@ class Annotator.Guest extends Annotator
...
@@ -226,6 +226,11 @@ class Annotator.Guest extends Annotator
this
.
removeEvents
()
this
.
removeEvents
()
createAnnotation
:
->
annotation
=
super
this
.
plugins
.
Bridge
.
sync
([
annotation
])
annotation
showViewer
:
(
annotations
)
=>
showViewer
:
(
annotations
)
=>
@
panel
?
.
notify
@
panel
?
.
notify
method
:
"showViewer"
method
:
"showViewer"
...
...
tests/js/directives/annotation-test.coffee
View file @
93590fd6
...
@@ -65,12 +65,6 @@ describe 'h.directives.annotation', ->
...
@@ -65,12 +65,6 @@ describe 'h.directives.annotation', ->
$scope
.
$digest
()
$scope
.
$digest
()
assert
.
isNull
(
controller
.
document
)
assert
.
isNull
(
controller
.
document
)
it
'skips the document object if the annotation has no targets'
,
->
annotation
.
target
=
[]
controller
=
createController
()
$scope
.
$digest
()
assert
.
isNull
(
controller
.
document
)
describe
'#reply'
,
->
describe
'#reply'
,
->
controller
=
null
controller
=
null
container
=
null
container
=
null
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment