Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
9465de91
Commit
9465de91
authored
Jan 31, 2022
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a note about a race condition in port discover vs unloading
parent
ebe7e380
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
0 deletions
+10
-0
guest.js
src/annotator/guest.js
+10
-0
No files found.
src/annotator/guest.js
View file @
9465de91
...
...
@@ -482,6 +482,16 @@ export class Guest {
_sendUnloadNotification
()
{
const
ports
=
[];
// There is currently a race condition where the guest can fail to notify
// the host and sidebar when it unloads if it has not yet received its ports
// for guest-host and guest-sidebar commmunication.
//
// For the moment this can be tolerated as guest frames are not displayed in
// the sidebar until the guest has received the port and sent a
// `documentInfoChanged` notification on it. Nevertheless the host / sidebar
// will be left with a disconnected PortRPC for the guest, so we should aim
// to fix this in future.
const
sidebarPort
=
this
.
_sidebarRPC
.
disconnect
();
if
(
sidebarPort
)
{
ports
.
push
(
sidebarPort
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment