Commit 966aee8a authored by Randall Leeds's avatar Randall Leeds

Revert "Don't propagate mouseUp events from the toolbar. Fixes #1169"

This reverts commit 28c48518c064b6c0769b43d7ddcdbbe89a169926.

Reverted until @csillag shows me why this is a significant win because
otherwise it is code here that has nothing to do with the toolbar.
parent c9a615d4
......@@ -21,7 +21,6 @@ class Annotator.Plugin.Toolbar extends Annotator.Plugin
window.annotator.showFrame()
else
window.annotator.hideFrame()
"mouseup": (event) -> event.stopPropagation()
,
"title": "Show Annotations"
"class": "alwaysonhighlights-icon"
......@@ -30,7 +29,6 @@ class Annotator.Plugin.Toolbar extends Annotator.Plugin
event.stopPropagation()
state = not window.annotator.visibleHighlights
window.annotator.setVisibleHighlights state
"mouseup": (event) -> event.stopPropagation()
,
"title": "Highlighting Mode"
"class": "highlighter-icon"
......@@ -40,7 +38,6 @@ class Annotator.Plugin.Toolbar extends Annotator.Plugin
state = not (window.annotator.tool is 'highlight')
tool = if state then 'highlight' else 'comment'
window.annotator.setTool tool
"mouseup": (event) -> event.stopPropagation()
,
"title": "New Comment"
"class": "commenter-icon"
......@@ -48,7 +45,6 @@ class Annotator.Plugin.Toolbar extends Annotator.Plugin
event.preventDefault()
event.stopPropagation()
window.annotator.addComment()
"mouseup": (event) -> event.stopPropagation()
]
pluginInit: ->
......@@ -63,7 +59,6 @@ class Annotator.Plugin.Toolbar extends Annotator.Plugin
.attr('href', '')
.attr('title', item.title)
.on('click', item.click)
.on('mouseup', item.mouseup)
.addClass(item.class)
button = $('<li></li>').append(anchor)
buttons.add button
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment