Merge pull request #1559 from hypothesis/use-fragment-to-pass-config

Use fragment instead of query to pass config to sidebar app

src/annotator/host.coffee

@@ -27,10 +27,8 @@ module.exports = class Host extends Guest
     configParam = 'config=' + encodeURIComponent(
       JSON.stringify(Object.assign({}, config, {sidebarAppUrl: undefined, pluginClasses: undefined }))
     )
-    if config.sidebarAppUrl and '?' in config.sidebarAppUrl
-      sidebarAppSrc = config.sidebarAppUrl + '&' + configParam
-    else
-      sidebarAppSrc = config.sidebarAppUrl + '?' + configParam
+
+    sidebarAppSrc = config.sidebarAppUrl + '#' + configParam
 
     # Create the iframe
     app = $('<iframe></iframe>')

src/annotator/test/host-test.coffee

@@ -78,7 +78,7 @@ describe 'Host', ->
       appURL = new URL('/base/annotator/test/empty.html', window.location.href)
       host = createHost({annotations: '1234'})
       configStr = encodeURIComponent(JSON.stringify({annotations: '1234'}))
-      assert.equal(host.frame[0].children[0].src, appURL + '?config=' + configStr)
+      assert.equal(host.frame[0].children[0].src, appURL + '#config=' + configStr)
 
     it 'adds drop shadow if the clean theme is enabled', ->
       host = createHost({theme: 'clean'})

src/sidebar/host-config.js

@@ -7,7 +7,8 @@ const queryString = require('query-string');
  * client.
  */
 function hostPageConfig(window) {
-  const configJSON = queryString.parse(window.location.search).config;
+  const configStr = window.location.hash.slice(1);
+  const configJSON = queryString.parse(configStr).config;
   const config = JSON.parse(configJSON || '{}');
 
   // Known configuration parameters which we will import from the host page.

src/sidebar/test/host-config-test.js

@@ -5,7 +5,7 @@ const hostPageConfig = require('../host-config');
 function fakeWindow(config) {
   return {
     location: {
-      search: '?config=' + JSON.stringify(config),
+      hash: '#config=' + JSON.stringify(config),
     },
   };
 }