Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
b89546ab
Commit
b89546ab
authored
Mar 12, 2015
by
Jake Hartnell
Committed by
Randall Leeds
Mar 17, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix bug with double highlight creation.
parent
02b13e2f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
7 deletions
+6
-7
annotation.coffee
h/static/scripts/directives/annotation.coffee
+6
-7
No files found.
h/static/scripts/directives/annotation.coffee
View file @
b89546ab
...
...
@@ -46,6 +46,7 @@ AnnotationController = [
@timestamp = null
model = $scope.annotationGet()
highlight = model.$highlight
original = null
vm = this
...
...
@@ -63,11 +64,8 @@ AnnotationController = [
# @returns {boolean} True if the annotation is a highlight.
###
this.isHighlight = ->
if model.id
model.target?.length and not model.references?.length and
not (model.text or model.deleted or model.tags?.length)
else
model.$highlight
model.target?.length and not model.references?.length and
not (model.text or model.deleted or model.tags?.length)
###
*
# @ngdoc method
...
...
@@ -267,11 +265,12 @@ AnnotationController = [
$scope.$emit('annotationUpdate')
# Save highlights once logged in.
if this.isHighlight()
if this.isHighlight()
and highlight
if model.user and not model.id
model.permissions = permissions.private()
model.$create().then ->
$rootScope.$emit('annotationCreated', model)
highlight = false # Prevents double highlight creation.
else
drafts.add model, => this.revert()
...
...
@@ -280,7 +279,7 @@ AnnotationController = [
, true
# Start editing brand new annotations immediately
unless model.id? or
this.isHighlight(
) then this.edit()
unless model.id? or
(this.isHighlight() and highlight
) then this.edit()
this
]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment