Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
bdd1a308
Commit
bdd1a308
authored
Nov 25, 2021
by
Eduardo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply suggestions from code review
Co-authored-by:
Robert Knight
<
robertknight@gmail.com
>
parent
f364519b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
3 deletions
+2
-3
sidebar.js
src/annotator/sidebar.js
+1
-1
port-provider.js
src/shared/port-provider.js
+1
-2
No files found.
src/annotator/sidebar.js
View file @
bdd1a308
...
@@ -219,7 +219,7 @@ export default class Sidebar {
...
@@ -219,7 +219,7 @@ export default class Sidebar {
}
}
/**
/**
*
Establish RPC channels from specific source frames
*
Setup communication with a frame that has connected to the host.
*
*
* @param {'guest'|'sidebar'} source
* @param {'guest'|'sidebar'} source
* @param {MessagePort} port
* @param {MessagePort} port
...
...
src/shared/port-provider.js
View file @
bdd1a308
...
@@ -136,8 +136,7 @@ export class PortProvider {
...
@@ -136,8 +136,7 @@ export class PortProvider {
/**
/**
* @param {'frameConnected'} eventName
* @param {'frameConnected'} eventName
* @param {(source: 'guest'|'sidebar', port: MessagePort) => void} handler - this handler
* @param {(source: 'guest'|'sidebar', port: MessagePort) => void} handler - this handler
* fires when a request for the host frame has been granted. Currently, only
* fires when a request for the host frame has been granted.
* the 'guest-host' channel triggers this listener.
*/
*/
on
(
eventName
,
handler
)
{
on
(
eventName
,
handler
)
{
this
.
_emitter
.
on
(
eventName
,
handler
);
this
.
_emitter
.
on
(
eventName
,
handler
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment