Commit bdd1a308 authored by Eduardo's avatar Eduardo

Apply suggestions from code review

Co-authored-by: 's avatarRobert Knight <robertknight@gmail.com>
parent f364519b
...@@ -219,7 +219,7 @@ export default class Sidebar { ...@@ -219,7 +219,7 @@ export default class Sidebar {
} }
/** /**
* Establish RPC channels from specific source frames * Setup communication with a frame that has connected to the host.
* *
* @param {'guest'|'sidebar'} source * @param {'guest'|'sidebar'} source
* @param {MessagePort} port * @param {MessagePort} port
......
...@@ -136,8 +136,7 @@ export class PortProvider { ...@@ -136,8 +136,7 @@ export class PortProvider {
/** /**
* @param {'frameConnected'} eventName * @param {'frameConnected'} eventName
* @param {(source: 'guest'|'sidebar', port: MessagePort) => void} handler - this handler * @param {(source: 'guest'|'sidebar', port: MessagePort) => void} handler - this handler
* fires when a request for the host frame has been granted. Currently, only * fires when a request for the host frame has been granted.
* the 'guest-host' channel triggers this listener.
*/ */
on(eventName, handler) { on(eventName, handler) {
this._emitter.on(eventName, handler); this._emitter.on(eventName, handler);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment