Commit c3a6bf6f authored by Robert Knight's avatar Robert Knight

Do not swallow exception if sourcemap upload fails

Throwing an exception in the context of a Promise
catch handler inside through.obj() just results in the
exception being silently swallowed.

Pass it to the through2 callback
so that Gulp exits with the correct status.
parent e6a0522e
......@@ -6,7 +6,7 @@ var gulpUtil = require('gulp-util');
var request = require('request');
var through = require('through2');
var SENTRY_API_ROOT = 'https://app.getsentry.com/api/0'
var SENTRY_API_ROOT = 'https://app.getsentry.com/api/0';
/**
* interface SentryOptions {
......@@ -119,7 +119,7 @@ module.exports = function uploadToSentry(opts, projects, release) {
})
.catch(function (err) {
gulpUtil.log('Sentry upload failed: ', err);
throw err;
callback(err);
});
});
};
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment