Commit ce3c76eb authored by Robert Knight's avatar Robert Knight

Update an obsolete comment about highlight styles

This comment was written prior to the change to draw highlights in an
SVG in PDFs.
parent 89591604
...@@ -53,15 +53,14 @@ ...@@ -53,15 +53,14 @@
background-color: transparent; background-color: transparent;
} }
// In document viewers where the highlight is drawn _on top of_ the text // Limit the number of different highlight shades by making highlights
// (eg. PDF.js) too many nested highlights can make the underlying text unreadable. // that are 3+ levels deep transparent.
// Therefore we make any highlights that are 3+ levels deep transparent.
// //
// In web pages highlights are drawn _underneath_ the text so nested // This was historically done to improve readability in PDFs [1], but that
// highlights don't reduce text contrast as much, but we still only use // is no longer an issue as in PDFs highlights are created by drawing
// two levels of highlight color for consistency. // SVGs on top of the <canvas>.
// //
// See https://github.com/hypothesis/client/issues/1995. // [1] https://github.com/hypothesis/client/issues/1995.
& .hypothesis-highlight { & .hypothesis-highlight {
background-color: transparent; background-color: transparent;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment