Merge pull request #459 from hypothesis/flash-decaf

Convert "flash" service to JS

src/sidebar/flash.coffee

-module.exports = ['toastr', (toastr) ->
-  info: angular.bind(toastr, toastr.info)
-  success: angular.bind(toastr, toastr.success)
-  warning: angular.bind(toastr, toastr.warning)
-  error: angular.bind(toastr, toastr.error)
-]

src/sidebar/flash.js

+'use strict';
+
+/**
+ * A service for displaying "flash" notification messages.
+ */
+
+// @ngInject
+function flash(toastr) {
+  return {
+    info: toastr.info.bind(toastr),
+    success: toastr.success.bind(toastr),
+    warning: toastr.warning.bind(toastr),
+    error: toastr.error.bind(toastr),
+  };
+}
+
+module.exports = flash;

src/sidebar/test/flash-test.js

+'use strict';
+
+var flash = require('../flash');
+
+describe('sidebar.flash', () => {
+  ['info', 'success', 'warning', 'error'].forEach(method => {
+    describe(`#${method}`, () => {
+      it(`calls toastr's "${method}" method`, () => {
+        var fakeToastr = {
+          info: sinon.stub(),
+          success: sinon.stub(),
+          warning: sinon.stub(),
+          error: sinon.stub(),
+        };
+
+        var svc = flash(fakeToastr);
+        svc[method]('message', 'title');
+
+        assert.calledWith(fakeToastr[method], 'message', 'title');
+      });
+    });
+  });
+});