Commit da3a3466 authored by Kyle Keating's avatar Kyle Keating Committed by Kyle Keating

Fix default value for showHighlights

The default was incorrectly set to null because the previous code was setting it to null, however that null value was used to then set it a second time to "always" Part of this refactor is making the code more clear so this logic is explicit. The defaultValue for showHighlight is in fact 'always'
parent 3a9d395a
......@@ -159,7 +159,7 @@ const configDefinitions = {
},
showHighlights: {
allowInBrowserExt: false,
defaultValue: null,
defaultValue: 'always',
getValue: settings => settings.showHighlights,
},
notebookAppUrl: {
......
......@@ -88,7 +88,7 @@ describe('annotator/config/index', function () {
query: 'fakeValue',
requestConfigFromFrame: null,
services: null,
showHighlights: null,
showHighlights: 'always',
sidebarAppUrl: 'fakeValue',
subFrameIdentifier: 'fakeValue',
theme: null,
......@@ -172,7 +172,7 @@ describe('annotator/config/index', function () {
query: null,
requestConfigFromFrame: null,
services: null,
showHighlights: null,
showHighlights: 'always',
sidebarAppUrl: null,
subFrameIdentifier: null,
theme: null,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment