Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
e01551a6
Unverified
Commit
e01551a6
authored
May 21, 2020
by
Lyza Gardner
Committed by
GitHub
May 21, 2020
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2189 from hypothesis/add-aria-expanded
Use `aria-expanded` instead of `aria-pressed` per a11y audit
parents
20796094
aac3fe5e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
top-bar-test.js
src/sidebar/components/test/top-bar-test.js
+2
-2
top-bar.js
src/sidebar/components/top-bar.js
+3
-3
No files found.
src/sidebar/components/test/top-bar-test.js
View file @
e01551a6
...
...
@@ -119,7 +119,7 @@ describe('TopBar', () => {
wrapper
.
update
();
assert
.
isTrue
(
helpButton
.
props
().
is
Press
ed
);
assert
.
isTrue
(
helpButton
.
props
().
is
Expand
ed
);
});
context
(
'help service handler configured in services'
,
()
=>
{
...
...
@@ -228,7 +228,7 @@ describe('TopBar', () => {
const
wrapper
=
createTopBar
();
const
shareButton
=
getButton
(
wrapper
,
'share'
);
assert
.
isTrue
(
shareButton
.
prop
(
'is
Press
ed'
));
assert
.
isTrue
(
shareButton
.
prop
(
'is
Expand
ed'
));
});
it
(
'displays search input in the sidebar'
,
()
=>
{
...
...
src/sidebar/components/top-bar.js
View file @
e01551a6
...
...
@@ -105,7 +105,7 @@ function TopBar({
<
Button
className
=
"top-bar__icon-button"
icon
=
"help"
is
Press
ed
=
{
currentActivePanel
===
uiConstants
.
PANEL_HELP
}
is
Expand
ed
=
{
currentActivePanel
===
uiConstants
.
PANEL_HELP
}
onClick
=
{
requestHelp
}
title
=
"Help"
useCompactStyle
...
...
@@ -135,7 +135,7 @@ function TopBar({
<
Button
className
=
"top-bar__icon-button"
icon
=
"share"
is
Press
ed
=
{
is
Expand
ed
=
{
currentActivePanel
===
uiConstants
.
PANEL_SHARE_ANNOTATIONS
}
onClick
=
{
toggleSharePanel
}
...
...
@@ -146,7 +146,7 @@ function TopBar({
<
Button
className
=
"top-bar__icon-button"
icon
=
"help"
is
Press
ed
=
{
currentActivePanel
===
uiConstants
.
PANEL_HELP
}
is
Expand
ed
=
{
currentActivePanel
===
uiConstants
.
PANEL_HELP
}
onClick
=
{
requestHelp
}
title
=
"Help"
useCompactStyle
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment